Skip to content

fix: Colour ignored when 0 is used as british-colour in Embed #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Paillat-dev wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −2
Open

fix: Colour ignored when 0 is used as british-colour in Embed #3256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92e4162
fix: Bug when 0 is used with british-colour in Embed init
Paillat-dev Jun 10, 2026
443e9f7
docs: CHANGELOG.md
Paillat-dev Jun 10, 2026
9bc7b1e
Merge branch 'master' into fix/embed-colour-black-ignored
Paillat-dev Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#3231](https://github.com/Pycord-Development/pycord/pull/3231))
- Allow `ForumTag` to be created without an emoji.
([#3245](https://github.com/Pycord-Development/pycord/pull/3245))
- Fix issue where `0` would be ignored as an `Embed`'s `colour` parameter.
([#3256](https://github.com/Pycord-Development/pycord/pull/3256))
- Fix a bug where `TextChannel.archived_threads` would ignore any limit parameter
smaller than 50 and use 50 instead.
([#3266](https://github.com/Pycord-Development/pycord/pull/3266))
Expand Down
3 changes: 1 addition & 2 deletions discord/embeds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
"EmbedProvider",
)


E = TypeVar("E", bound="Embed")

if TYPE_CHECKING:
Expand Down Expand Up @@ -364,7 +363,7 @@ def __init__(
image: str | EmbedMedia | None = None,
thumbnail: str | EmbedMedia | None = None,
):
self.colour = colour if colour else color
self.colour = colour if colour is not None else color
self.title = title
self.type = type
self.url = url
Expand Down
Loading