fix: Edit both current user @me and by id if applicable#3258
Draft
Paillat-dev wants to merge 1 commit into
Draft
fix: Edit both current user @me and by id if applicable#3258Paillat-dev wants to merge 1 commit into
Paillat-dev wants to merge 1 commit into
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3258/head:pr-3258
git checkout pr-3258This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3258/head |
Member
|
Yes we should aim for a current member function. It makes the most sense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, passing both
avatarandrolesfor e.g. would fail at setting the guild-specific avatar.I am not sure if this is the best fix, specifically since for e.g.
nickcan both be set with Modify Guild Member and Modify Current Member (with manage_nicknames vs change_nickname). Maybe having manage_nicknames also implicitly allows change_nickname, that would make sense but idk if it is being authorized on an API level.Maybe we should create a different
Guild.modify_current_member(or other name), and deprecate these in order to be closer to the API and have better and clearer logic here ?This bug was identified by Anthropic Fable 5, then verified and patched by me (pending discussion).
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.