Skip to content

fix: Edit both current user @me and by id if applicable#3258

Draft
Paillat-dev wants to merge 1 commit into
masterfrom
fix/edit-member-me-multi
Draft

fix: Edit both current user @me and by id if applicable#3258
Paillat-dev wants to merge 1 commit into
masterfrom
fix/edit-member-me-multi

Conversation

@Paillat-dev

Copy link
Copy Markdown
Member

Summary

Currently, passing both avatar and roles for e.g. would fail at setting the guild-specific avatar.

I am not sure if this is the best fix, specifically since for e.g. nick can both be set with Modify Guild Member and Modify Current Member (with manage_nicknames vs change_nickname). Maybe having manage_nicknames also implicitly allows change_nickname, that would make sense but idk if it is being authorized on an API level.

Maybe we should create a different Guild.modify_current_member (or other name), and deprecate these in order to be closer to the API and have better and clearer logic here ?

This bug was identified by Anthropic Fable 5, then verified and patched by me (pending discussion).

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@Paillat-dev Paillat-dev requested review from a team and VincentRPS June 10, 2026 14:42
@Paillat-dev Paillat-dev added the hold: changelog This pull request is missing a changelog entry label Jun 10, 2026
@Paillat-dev Paillat-dev added the hold: discussion This pull request needs to be further discussed between maintainers label Jun 10, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Pycord Jun 10, 2026
@Paillat-dev Paillat-dev requested a review from a team as a code owner June 10, 2026 14:42
@Paillat-dev Paillat-dev requested review from Lulalaby and removed request for a team June 10, 2026 14:42
@pycord-app

pycord-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3258/head:pr-3258
git checkout pr-3258

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3258/head

@Paillat-dev Paillat-dev marked this pull request as draft June 10, 2026 14:42
@Lulalaby

Copy link
Copy Markdown
Member

Yes we should aim for a current member function. It makes the most sense

@Paillat-dev Paillat-dev added the bug Something isn't working label Jun 10, 2026
@Paillat-dev Paillat-dev added this to the 2.8.1 milestone Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working hold: changelog This pull request is missing a changelog entry hold: discussion This pull request needs to be further discussed between maintainers

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants