Skip to content

fix: Fix Poll.to_dict and add better types #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Paillat-dev wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −5
Open

fix: Fix Poll.to_dict and add better types #3261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbf257d
fix: Fix `Poll.to_dict` and add better types
Paillat-dev Jun 10, 2026
720a456
docs: CHANGELOG.md
Paillat-dev Jun 10, 2026
b3be8c3
Merge branch 'master' into fix/poll-to-dict-results-type
Paillat-dev Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#3231](https://github.com/Pycord-Development/pycord/pull/3231))
- Allow `ForumTag` to be created without an emoji.
([#3245](https://github.com/Pycord-Development/pycord/pull/3245))
- Fix `TypeError` in `Poll.to_dict` for closed polls.
([#3261](https://github.com/Pycord-Development/pycord/pull/3261))

### Deprecated

Expand Down
10 changes: 5 additions & 5 deletions discord/poll.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,9 @@ def __init__(
self.duration: int | None = duration
self.allow_multiselect: bool = allow_multiselect
self.layout_type: PollLayoutType = layout_type
self.results = None
self._expiry = None
self._message = None
self.results: PollResults | None = None
self._expiry: str | None = None
self._message: Message | PartialMessage | None = None

@cached_property
def expiry(self) -> datetime.datetime | None:
Expand All @@ -372,8 +372,8 @@ def to_dict(self) -> PollPayload:
"allow_multiselect": self.allow_multiselect,
"layout_type": self.layout_type.value,
}
if self.results:
dict_["results"] = [r.to_dict() for r in self.results]
if self.results is not None:
Comment thread
Paillat-dev marked this conversation as resolved.
dict_["results"] = self.results.to_dict()
if self._expiry:
dict_["expiry"] = self._expiry
return dict_
Expand Down
Loading