Skip to content

fix: PartialSoundboardSound equality check #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Paillat-dev wants to merge 3 commits into
base: master
Choose a base branch
from
+3 −2
Open

fix: PartialSoundboardSound equality check #3262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eceb17f
fix: PartialSoundboardSound equality check
Paillat-dev Jun 10, 2026
9fa1f4d
docs: CHANGELOG.md
Paillat-dev Jun 10, 2026
9702f01
Merge branch 'master' into fix/partial-soundboard-sound-eq
Paillat-dev Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#3231](https://github.com/Pycord-Development/pycord/pull/3231))
- Allow `ForumTag` to be created without an emoji.
([#3245](https://github.com/Pycord-Development/pycord/pull/3245))
- Fix `TypeError` when checking equality of two `PartialSoundboardSound` instances.
([#3262](https://github.com/Pycord-Development/pycord/pull/3262))

### Deprecated

Expand Down
3 changes: 1 addition & 2 deletions discord/soundboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
from .http import HTTPClient
from .state import ConnectionState


__all__ = (
"PartialSoundboardSound",
"SoundboardSound",
Expand Down Expand Up @@ -100,7 +99,7 @@ def _from_data(
def __eq__(
self, other: PartialSoundboardSound
) -> bool: # pyright: ignore[reportIncompatibleMethodOverride]
if isinstance(other, self, __class__):
if isinstance(other, __class__):
return self.id == other.id
return NotImplemented

Expand Down
Loading