Move task lifecycle guidance to review notifications

Author: Pyiner

garyx-gateway/src/routes/tests.rs

@@ -1931,6 +1931,8 @@ async fn task_create_with_agent_assignee_queues_agent_dispatch() {
     assert_eq!(runs[0].thread_id, payload["thread_id"].as_str().unwrap());
     assert!(runs[0].message.contains(task_id));
     assert!(runs[0].message.contains("Move this task to review"));
+    assert!(!runs[0].message.contains("Garyx will move this task"));
+    assert!(!runs[0].message.contains("mark it done"));
     assert_eq!(runs[0].metadata["task_auto_start"], true);
     assert_eq!(
         runs[0].workspace_dir.as_deref(),
@@ -2048,6 +2050,8 @@ async fn task_assign_queues_dispatch_with_original_body() {
             .contains("Use this original body when assigning later.")
     );
     assert!(!runs[0].message.contains("Title: Assignable task"));
+    assert!(!runs[0].message.contains("Garyx will move this task"));
+    assert!(!runs[0].message.contains("mark it done"));
 }
 
 #[tokio::test]

garyx-gateway/src/task_notifications.rs

@@ -178,7 +178,12 @@ pub(crate) fn format_task_ready_notification(
 Task {body_task_id} is ready for review: {title}\n\n\
 {final_message}\n\n\
 View details:\n\
-garyx task get {body_task_id}\n\
+garyx task get {body_task_id}\n\n\
+Review next:\n\
+If changes are needed, move the task back to in progress and send feedback to the task thread:\n\
+garyx task update {body_task_id} --status in_progress --note \"needs changes: summary\"\n\n\
+If approved, mark it done:\n\
+garyx task update {body_task_id} --status done --note \"approved by reviewer\"\n\
 </{TASK_NOTIFICATION_TAG}>"
     )
 }

garyx-gateway/src/task_notifications/tests.rs

@@ -181,6 +181,13 @@ fn format_wraps_notification_with_single_outer_xml_tag() {
     ));
     assert!(text.contains("Task #TASK-42 is ready for review: Ship task notifications"));
     assert!(text.contains("Done."));
+    assert!(text.contains("Review next:"));
+    assert!(text.contains(
+        "garyx task update #TASK-42 --status in_progress --note \"needs changes: summary\""
+    ));
+    assert!(
+        text.contains("garyx task update #TASK-42 --status done --note \"approved by reviewer\"")
+    );
     assert!(text.contains("</ garyx_task_notification>"));
     assert!(text.ends_with("</garyx_task_notification>"));
 }

garyx-gateway/src/tasks.rs

@@ -1069,11 +1069,11 @@ fn task_auto_dispatch_message(
         .map(str::trim)
         .filter(|value| !value.is_empty());
     match body {
-        Some(body) => format!(
-            "Task {task_id} has been assigned to you and is already in progress.\n\n{body}\n\nGaryx will move this task to review when this run stops. Do not mark it done just because you finished; after a user, reviewer, or task creator explicitly approves it, you may record that approval with `garyx task update {task_id} --status done --note \"approved by <name>\"`."
-        ),
+        Some(body) => {
+            format!("Task {task_id} has been assigned to you and is already in progress.\n\n{body}")
+        }
         None => format!(
-            "Task {task_id} has been assigned to you and is already in progress.\n\nTitle: {title}\n\nGaryx will move this task to review when this run stops. Do not mark it done just because you finished; after a user, reviewer, or task creator explicitly approves it, you may record that approval with `garyx task update {task_id} --status done --note \"approved by <name>\"`."
+            "Task {task_id} has been assigned to you and is already in progress.\n\nTitle: {title}"
         ),
     }
 }