fix(desktop): scope task tree to primary threads

Author: Pyiner

desktop/garyx-desktop/src/renderer/src/app-shell/components/ThreadPage.tsx

@@ -589,6 +589,7 @@ export function ThreadPage({
       >
         {shouldShowThreadTaskTreePopover({
           inspectorOpen,
+          isSideChatSurface,
           selectedThreadId,
           threadLogsOpen,
         }) && selectedThreadId ? (

desktop/garyx-desktop/src/renderer/src/app-shell/components/thread-task-tree-popover-model.test.mjs

@@ -223,6 +223,7 @@ test("task tree popover yields to inspector panel", () => {
   assert.equal(
     shouldShowThreadTaskTreePopover({
       inspectorOpen: false,
+      isSideChatSurface: false,
       selectedThreadId: "thread::current",
       threadLogsOpen: false,
     }),
@@ -231,6 +232,7 @@ test("task tree popover yields to inspector panel", () => {
   assert.equal(
     shouldShowThreadTaskTreePopover({
       inspectorOpen: true,
+      isSideChatSurface: false,
       selectedThreadId: "thread::current",
       threadLogsOpen: false,
     }),
@@ -239,6 +241,7 @@ test("task tree popover yields to inspector panel", () => {
   assert.equal(
     shouldShowThreadTaskTreePopover({
       inspectorOpen: false,
+      isSideChatSurface: false,
       selectedThreadId: "thread::current",
       threadLogsOpen: true,
     }),
@@ -247,13 +250,26 @@ test("task tree popover yields to inspector panel", () => {
   assert.equal(
     shouldShowThreadTaskTreePopover({
       inspectorOpen: false,
+      isSideChatSurface: false,
       selectedThreadId: null,
       threadLogsOpen: false,
     }),
     false,
   );
 });
 
+test("task tree popover stays on the primary thread surface", () => {
+  assert.equal(
+    shouldShowThreadTaskTreePopover({
+      inspectorOpen: false,
+      isSideChatSurface: true,
+      selectedThreadId: "thread::side-chat",
+      threadLogsOpen: false,
+    }),
+    false,
+  );
+});
+
 test("fallback rows preserve original parent edges for done ancestors", () => {
   const doneAncestor = task({ number: 1, status: "done" });
   const activeChild = task({

desktop/garyx-desktop/src/renderer/src/app-shell/components/thread-task-tree-popover-model.ts

@@ -49,12 +49,14 @@ export function isCurrentTaskTreeNode(
 
 export function shouldShowThreadTaskTreePopover(input: {
   inspectorOpen: boolean;
+  isSideChatSurface: boolean;
   selectedThreadId: string | null;
   threadLogsOpen: boolean;
 }): boolean {
   return Boolean(
     input.selectedThreadId &&
       !input.inspectorOpen &&
+      !input.isSideChatSurface &&
       !input.threadLogsOpen,
   );
 }