- Added render throttling

- Fixed some small bugs

Author: NoryiE

.gitignore

@@ -6,6 +6,7 @@ ascii.lua
 tests
 testWorkflows
 .vscode
+.idea
 todo.txt
 Flexbox2.lua
 markdown.lua

src/elements/BaseElement.lua

@@ -466,7 +466,7 @@ end
 --- @param stateName string The state to remove
 --- @return BaseElement self
 function BaseElement:unregisterState(stateName)
-    self._stateRegistry[stateName] = nil
+    self._registeredStates[stateName] = nil
     self:unsetState(stateName)
     return self
 end

src/elements/BaseFrame.lua

@@ -201,7 +201,6 @@ end
 --- @protected
 function BaseFrame:mouse_up(button, x, y)
     Container.mouse_up(self, button, x, y)
-    Container.mouse_release(self, button, x, y)
 end
 
 --- @shortDescription Resizes the Frame

src/elements/Container.lua

@@ -340,7 +340,7 @@ function Container:getChild(path)
                     return v
                 else
                     if(v:isType("Container"))then
-                       return v:find(table.concat(parts, "/", 2))
+                       return v:getChild(table.concat(parts, "/", 2))
                     end
                 end
             end
@@ -441,6 +441,7 @@ function Container:mouse_up(button, x, y)
         if(success)then
             return true
         end
+        return true
     end
     return false
 end
@@ -453,7 +454,11 @@ end
 function Container:mouse_release(button, x, y)
     VisualElement.mouse_release(self, button, x, y)
     local args = convertMousePosition(self, "mouse_release", button, x, y)
-    self:callChildrenEvent(false, "mouse_release", table.unpack(args))
+    for _, child in ipairs(self._values.children) do
+        if not child._destroyed then
+            child:dispatchEvent("mouse_release", table.unpack(args))
+        end
+    end
 end
 
 --- @shortDescription Handles mouse move events

src/elements/Dialog.lua

@@ -77,6 +77,25 @@ function Dialog:close()
     return self
 end
 
+--- Calculates the number of lines needed to display a message at a given width
+--- @private
+function Dialog:calcLines(message, width)
+    local available = width - 3  -- left padding + right border
+    local lines = 1
+    local col = 0
+    for word in message:gmatch("%S+") do
+        if col > 0 and col + 1 + #word > available then
+            lines = lines + 1
+            col = #word
+        else
+            col = col == 0 and #word or col + 1 + #word
+        end
+    end
+    -- Also count explicit newlines in message
+    for _ in message:gmatch("\n") do lines = lines + 1 end
+    return lines
+end
+
 --- Creates a simple alert dialog
 --- @shortDescription Creates a simple alert dialog
 --- @param title string The alert title
@@ -86,23 +105,29 @@ end
 function Dialog:alert(title, message, callback)
     self:clear()
     self.set("title", title)
-    self.set("height", 8)
+
+    local w = self.getResolved("width")
+    local msgLines = self:calcLines(message, w)
+    -- 1 border top + 1 title + 1 gap + msgLines + 1 gap + 1 button + 1 gap + 1 border bottom
+    local h = 2 + 1 + 1 + msgLines + 1 + 1 + 1
+    self.set("height", h)
 
     self:addLabel({
         text = message,
         x = 2, y = 3,
-        width = self.getResolved("width") - 3,
-        height = 3,
+        width = w - 3,
+        height = msgLines,
+        autoSize = false,
         foreground = colors.white
     })
 
     local btnWidth = 10
-    local btnX = math.floor((self.getResolved("width") - btnWidth) / 2) + 1
+    local btnX = math.floor((w - btnWidth) / 2) + 1
 
     self:addButton({
         text = "OK",
         x = btnX,
-        y = self.getResolved("height") - 2,
+        y = h - 2,
         width = btnWidth,
         height = 1,
         background = self.getResolved("primaryColor"),
@@ -124,25 +149,30 @@ end
 function Dialog:confirm(title, message, callback)
     self:clear()
     self.set("title", title)
-    self.set("height", 8)
+
+    local w = self.getResolved("width")
+    local msgLines = self:calcLines(message, w)
+    local h = 2 + 1 + 1 + msgLines + 1 + 1 + 1
+    self.set("height", h)
 
     self:addLabel({
         text = message,
         x = 2, y = 3,
-        width = self.getResolved("width") - 3,
-        height = 3,
+        width = w - 3,
+        height = msgLines,
+        autoSize = false,
         foreground = colors.white
     })
 
     local btnWidth = 10
     local spacing = 2
     local totalWidth = btnWidth * 2 + spacing
-    local startX = math.floor((self.getResolved("width") - totalWidth) / 2) + 1
+    local startX = math.floor((w - totalWidth) / 2) + 1
 
     self:addButton({
         text = "Cancel",
         x = startX,
-        y = self.getResolved("height") - 2,
+        y = h - 2,
         width = btnWidth,
         height = 1,
         background = self.getResolved("secondaryColor"),
@@ -155,7 +185,7 @@ function Dialog:confirm(title, message, callback)
     self:addButton({
         text = "OK",
         x = startX + btnWidth + spacing,
-        y = self.getResolved("height") - 2,
+        y = h - 2,
         width = btnWidth,
         height = 1,
         background = self.getResolved("primaryColor"),

src/elements/Input.lua

@@ -217,8 +217,7 @@ end
 --- @shortDescription Handles a blur event
 --- @protected
 function Input:blur()
-    VisualElement.blur(self)
-    self:setCursor(1, 1, false, self.getResolved("cursorColor") or self.getResolved("foreground"))
+    VisualElement.blur(self) 
     self:updateRender()
 end
 

src/elements/TextBox.lua

@@ -1143,10 +1143,28 @@ function TextBox:render()
         local relativeY = self.getResolved("cursorY") - scrollY
         if relativeX >= 1 and relativeX <= width and relativeY >= 1 and relativeY <= height then
             self:setCursor(relativeX, relativeY, true, self.getResolved("cursorColor") or foreground)
+        else
+            self:setCursor(relativeX, relativeY, false, self.getResolved("cursorColor") or foreground)
         end
     end
 end
 
+--- @shortDescription Handles a focus event
+--- @protected
+function TextBox:focus()
+    VisualElement.focus(self)
+    local scrollX = self.getResolved("scrollX")
+    local scrollY = self.getResolved("scrollY")
+    local relativeX = self.getResolved("cursorX") - scrollX
+    local relativeY = self.getResolved("cursorY") - scrollY
+    local width = self.getResolved("width")
+    local height = self.getResolved("height")
+    if relativeX >= 1 and relativeX <= width and relativeY >= 1 and relativeY <= height then
+        self:setCursor(relativeX, relativeY, true, self.getResolved("cursorColor") or self.getResolved("foreground"))
+    end
+    self:updateRender()
+end
+
 function TextBox:destroy()
     if self._autoCompleteFrame and not self._autoCompleteFrame._destroyed then
         self._autoCompleteFrame:destroy()

src/elements/VisualElement.lua

@@ -11,9 +11,21 @@ local VisualElement = setmetatable({}, BaseElement)
 VisualElement.__index = VisualElement
 
 ---@property x number 1 The horizontal position relative to parent
-VisualElement.defineProperty(VisualElement, "x", {default = 1, type = "number", canTriggerRender = true})
+VisualElement.defineProperty(VisualElement, "x", {default = 1, type = "number", canTriggerRender = true, setter = function(self, value)
+    if self.parent then
+        self.parent.set("childrenSorted", false)
+        self.parent.set("childrenEventsSorted", false)
+    end
+    return value
+end})
 ---@property y number 1 The vertical position relative to parent
-VisualElement.defineProperty(VisualElement, "y", {default = 1, type = "number", canTriggerRender = true})
+VisualElement.defineProperty(VisualElement, "y", {default = 1, type = "number", canTriggerRender = true, setter = function(self, value)
+    if self.parent then
+        self.parent.set("childrenSorted", false)
+        self.parent.set("childrenEventsSorted", false)
+    end
+    return value
+end})
 ---@property z number 1 The z-index for layering elements
 VisualElement.defineProperty(VisualElement, "z", {default = 1, type = "number", canTriggerRender = true, setter = function(self, value)
     if self.parent then
@@ -29,9 +41,21 @@ VisualElement.defineProperty(VisualElement, "constraints", {
 })
 
 ---@property width number 1 The width of the element
-VisualElement.defineProperty(VisualElement, "width", {default = 1, type = "number", canTriggerRender = true})
+VisualElement.defineProperty(VisualElement, "width", {default = 1, type = "number", canTriggerRender = true, setter = function(self, value)
+    if self.parent then
+        self.parent.set("childrenSorted", false)
+        self.parent.set("childrenEventsSorted", false)
+    end
+    return value
+end})
 ---@property height number 1 The height of the element
-VisualElement.defineProperty(VisualElement, "height", {default = 1, type = "number", canTriggerRender = true})
+VisualElement.defineProperty(VisualElement, "height", {default = 1, type = "number", canTriggerRender = true, setter = function(self, value)
+    if self.parent then
+        self.parent.set("childrenSorted", false)
+        self.parent.set("childrenEventsSorted", false)
+    end
+    return value
+end})
 ---@property background color black The background color
 VisualElement.defineProperty(VisualElement, "background", {default = colors.black, type = "color", canTriggerRender = true})
 ---@property foreground color white The text/foreground color
@@ -75,6 +99,7 @@ VisualElement.combineProperties(VisualElement, "size", "width", "height")
 VisualElement.combineProperties(VisualElement, "color", "foreground", "background")
 
 ---@event onClick {button string, x number, y number} Fired on mouse click
+---@event onDoubleClick {button, x, y} Fired on double click (two clicks within 400ms)
 ---@event onClickUp {button, x, y} Fired on mouse button release
 ---@event onRelease {button, x, y} Fired when mouse leaves while clicked
 ---@event onDrag {button, x, y} Fired when mouse moves while clicked
@@ -91,11 +116,12 @@ VisualElement.defineEvent(VisualElement, "focus")
 VisualElement.defineEvent(VisualElement, "blur")
 
 VisualElement.registerEventCallback(VisualElement, "Click", "mouse_click", "mouse_up")
+VisualElement.registerEventCallback(VisualElement, "DoubleClick", "mouse_double_click", "mouse_click")
 VisualElement.registerEventCallback(VisualElement, "ClickUp", "mouse_up", "mouse_click")
 VisualElement.registerEventCallback(VisualElement, "Drag", "mouse_drag", "mouse_click", "mouse_up")
 VisualElement.registerEventCallback(VisualElement, "Scroll", "mouse_scroll")
 VisualElement.registerEventCallback(VisualElement, "Enter", "mouse_enter", "mouse_move")
-VisualElement.registerEventCallback(VisualElement, "LeEave", "mouse_leave", "mouse_move")
+VisualElement.registerEventCallback(VisualElement, "Leave", "mouse_leave", "mouse_move")
 VisualElement.registerEventCallback(VisualElement, "Focus", "focus", "blur")
 VisualElement.registerEventCallback(VisualElement, "Blur", "blur", "focus")
 VisualElement.registerEventCallback(VisualElement, "Key", "key", "key_up")
@@ -780,10 +806,22 @@ end
 --- @param y number The y position of the click
 --- @return boolean clicked Whether the element was clicked
 --- @protected
+local DOUBLE_CLICK_THRESHOLD = 0.4  -- seconds
+
 function VisualElement:mouse_click(button, x, y)
     if self:isInBounds(x, y) then
         self:setState("clicked")
-        self:fireEvent("mouse_click", button, self:getRelativePosition(x, y))
+        local rx, ry = self:getRelativePosition(x, y)
+        local now = os.clock()
+        local last = self._lastClick
+        if last and (now - last.time) <= DOUBLE_CLICK_THRESHOLD
+                 and last.button == button then
+            self._lastClick = nil
+            self:fireEvent("mouse_double_click", button, rx, ry)
+        else
+            self._lastClick = { time = now, button = button }
+            self:fireEvent("mouse_click", button, rx, ry)
+        end
         return true
     end
     return false
@@ -824,16 +862,16 @@ end
 --- @protected
 function VisualElement:mouse_move(_, x, y)
     if(x==nil)or(y==nil)then return false end
-    local hover = self.getResolved("hover")
+    local hover = self:hasState("hover")
     if(self:isInBounds(x, y))then
         if(not hover)then
-            self.set("hover", true)
+            self:setState("hover")
             self:fireEvent("mouse_enter", self:getRelativePosition(x, y))
         end
         return true
     else
         if(hover)then
-            self.set("hover", false)
+            self:unsetState("hover")
             self:fireEvent("mouse_leave", self:getRelativePosition(x, y))
         end
     end
@@ -899,13 +937,6 @@ function VisualElement:setFocused(focused, internal)
     return self
 end
 
---- Gets whether this element is focused
---- @shortDescription Checks if element is focused
---- @return boolean isFocused
-function VisualElement:isFocused()
-    return self:hasState("focused")
-end
-
 --- @shortDescription Handles a focus event
 --- @protected
 function VisualElement:focus()
@@ -916,8 +947,7 @@ end
 --- @protected
 function VisualElement:blur()
     self:fireEvent("blur")
-    -- Attempt to clear cursor; signature may expect (x,y,blink,fg,bg)
-    pcall(function() self:setCursor(1,1,false, self.get and self.getResolved("foreground")) end)
+    self:setCursor(1, 1, false, self.getResolved("foreground"))
 end
 
 --- Gets whether this element is focused

src/main.lua

@@ -34,6 +34,7 @@ end
 local main = nil
 local focusedFrame = nil
 local activeFrames = {}
+local THROTTLE_TIME = 0
 local _type = type
 
 local lazyElements = {}
@@ -298,10 +299,15 @@ local function updateEvent(event, ...)
     end
 end
 
+local lastRenderTime = 0
 local function renderFrames()
-    for _, frame in pairs(activeFrames)do
-        frame:render()
-        frame:postRender()
+    local currentTime = os.clock()
+    if currentTime - lastRenderTime >= THROTTLE_TIME then
+        for _, frame in pairs(activeFrames)do
+            frame:render()
+            frame:postRender()
+        end
+        lastRenderTime = currentTime
     end
 end
 
@@ -498,6 +504,15 @@ function basalt.requireElements(elements, autoLoad)
     return true
 end
 
+--- Sets the render throttle time in seconds (default: 0, no throttling)
+--- @shortDescription Sets the render throttle time
+--- @param time number The minimum time in seconds between renders
+--- @usage basalt.setRenderThrottleTime(0.1) -- Throttle rendering to 0.1 seconds
+function basalt.setRenderThrottleTime(time)
+    expect(1, time, "number")
+    THROTTLE_TIME = time
+end
+
 --- Loads a manifest file that describes element requirements and configuration
 --- @shortDescription Loads an application manifest
 --- @param path string The path to the manifest file

src/plugins/animation.lua

@@ -549,7 +549,7 @@ Animation.registerAnimation("entries", {
             index = #list
         end
         anim.element.set(anim.args[1], list[index])
-
+        return progress >= 1
     end,
 
     complete = function(anim)