#4 Type Hints

Author: Tomas-Pytel

fastapi_featureflags/main.py

@@ -9,31 +9,34 @@ class FeatureFlags(object):
     features = {}
 
     @staticmethod
-    def load_conf_from_url(conf_from_url):
+    def load_conf_from_url(conf_from_url: str) -> bool:
         FeatureFlags.features.clear()
         FeatureFlags.conf_from_url = conf_from_url
         params = requests.get(conf_from_url).json()
         for k, v in params.items():
             FeatureFlags.features[k] = v
+        return True
 
     @staticmethod
-    def load_conf_from_json(conf_from_json):
+    def load_conf_from_json(conf_from_json: str) -> bool:
         FeatureFlags.features.clear()
         FeatureFlags.conf_from_json = conf_from_json
         with open(conf_from_json, "r") as f:
             params = json.loads(f.read())
             for k, v in params.items():
                 FeatureFlags.features[k] = v
+        return True
 
     @staticmethod
-    def load_conf_from_dict(conf_from_dict):
+    def load_conf_from_dict(conf_from_dict: dict) -> bool:
         FeatureFlags.features.clear()
         FeatureFlags.conf_from_dict = conf_from_dict
         for k, v in conf_from_dict.items():
             FeatureFlags.features[k] = v
+        return True
 
     @staticmethod
-    def reload_feature_flags():
+    def reload_feature_flags() -> bool:
         FeatureFlags.features.clear()
         if FeatureFlags.conf_from_url:
             FeatureFlags.load_conf_from_url(FeatureFlags.conf_from_url)
@@ -48,32 +51,32 @@ def reload_feature_flags():
             return False
 
     @classmethod
-    def handle_feature(cls, feature_name):
+    def handle_feature(cls, feature_name: str):
         features = cls.features
         if features.get(feature_name, False) is False:
             features[feature_name] = False
 
     @classmethod
-    def is_enabled(cls, feature_name):
-        features = cls.features
-        return features.get(feature_name, False)
+    def get_features(cls) -> dict:
+        return cls.features
 
     @classmethod
-    def get_features(cls):
-        return cls.features
+    def is_enabled(cls, feature_name: str) -> bool:
+        features = cls.features
+        return features.get(feature_name, False)
 
     @classmethod
-    def enable_feature(cls, feature_name):
+    def enable_feature(cls, feature_name: str) -> bool:
         cls.features[feature_name] = True
         return cls.features[feature_name]
 
     @classmethod
-    def disable_feature(cls, feature_name):
+    def disable_feature(cls, feature_name: str) -> bool:
         cls.features[feature_name] = False
         return cls.features[feature_name]
 
 
-def feature_flag(feature_name):
+def feature_flag(feature_name: str):
     def decorator(function):
         def wrapper(*args, **kwargs):
             FeatureFlags.handle_feature(feature_name)
@@ -87,6 +90,6 @@ def wrapper(*args, **kwargs):
     return decorator
 
 
-def feature_enabled(feature_name):
+def feature_enabled(feature_name: str) -> bool:
     FeatureFlags.handle_feature(feature_name)
     return FeatureFlags.is_enabled(feature_name)