Skip to content

Commit e2c467d

Browse files
committed
Fix CI: use [test] extras instead of [dev] to avoid visdom build failure
The [dev] extras include visdom (via [optional]), which fails to build in pip's isolated build environments because visdom's setup.py imports pkg_resources from setuptools, which is not available in isolated builds with newer pip versions. The formatting workflow only needs linting tools and the pytest workflow only needs test tools, so [test] extras are sufficient for both.
1 parent 95cf68e commit e2c467d

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/check-formatting.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
run: |
2828
python -m pip install --upgrade pip setuptools wheel
2929
python setup.py install_egg_info # Workaround https://github.com/pypa/pip/issues/4537
30-
pip install -e .[dev]
30+
pip install -e .[test]
3131
pip install black flake8 isort --upgrade # Testing packages
3232
- name: Check code format with black and isort
3333
run: |

.github/workflows/run-pytest.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ jobs:
2727
run: |
2828
python -m pip install --upgrade pip setuptools wheel
2929
pip install pytest pytest-xdist # Testing packages
30-
pip uninstall textattack --yes # Remove TA if it's already installed
30+
pip uninstall textattack --yes # Remove TA if it's already installed
3131
python setup.py install_egg_info # Workaround https://github.com/pypa/pip/issues/4537
32-
pip install -e .[dev]
32+
pip install -e .[test]
3333
pip freeze
3434
- name: Free disk space
3535
run: |

0 commit comments

Comments
 (0)