Skip to content

cusp correction for hydrogen#6

Open
Paul-St-Young wants to merge 1 commit into
QMCPACK:mainfrom
Paul-St-Young:cusp_corr
Open

cusp correction for hydrogen#6
Paul-St-Young wants to merge 1 commit into
QMCPACK:mainfrom
Paul-St-Young:cusp_corr

Conversation

@Paul-St-Young
Copy link
Copy Markdown

No description provided.

Comment thread src/pw2qmcpack.f90
jastrow(ik)=CDEXP(-jastrow(ik))
enddo
! Finished Construct RPA Jastrow
endif ! cusp_corr
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please organize both blocks of code inside if statement into subroutines?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also document what these subroutines do.

@Paul-St-Young
Copy link
Copy Markdown
Author

Oops, I didn't actually mean to submit a PR.
Just wanted to see the file changes on GitHub diff.

This is a pretty specialized routine to cusp correct orbitals in PW basis, but only works for hydrogen at the moment.

I may get some time over the winter break to make it nicer.
Although, if you don't think it would be generally useful, then feel free to close the PR.

@ye-luo
Copy link
Copy Markdown
Collaborator

ye-luo commented Nov 14, 2025

Oops, I didn't actually mean to submit a PR. Just wanted to see the file changes on GitHub diff.

This is a pretty specialized routine to cusp correct orbitals in PW basis, but only works for hydrogen at the moment.

I may get some time over the winter break to make it nicer. Although, if you don't think it would be generally useful, then feel free to close the PR.

As long as the source code is well contained and this feature is well documented, I'm inclined to merge. Take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants