Update multi extents

[correaa]

Proposed changes

Update external lib multi to the new version with renamed functions

What type(s) of changes does this code introduce?

• Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

• No

What systems has this change been tested on?

nvcc 12, ubuntu 26.04

Checklist

• • [x ] I have read the pull request guidance and develop docs
• • [ ]x This PR is up to date with the current state of 'develop'
• • Code added or changed in the PR has been clang-formatted
• • [x ] This PR adds tests to cover any new code, or to catch a bug that is being fixed
• • Documentation has been added (if appropriate)

[prckent]

Hi Alfredo - Thanks for the update. What is the easiest way to see which version of multi this corresponds to? / what is the released version that this corresponds to?

[prckent]

Test this please

[correaa]

This doesn't correspond to a release number. I can release a number before we merge this. There is no point in releasing a number before we know it can be merged to
Qmcpack, because one might need yet another release immediately after.

Having said that, one can always do git log and get the SHA, no?

[correaa]

There are amdclang error in the CI but they don't seem related to Multi. Are they?

[prckent]

Looks like a clear error when used with ROCm 7.2.3:

In file included from /opt/rocm-7.2.3/lib/llvm/bin/../../../include/rocprim/config.hpp:26:
/opt/rocm-7.2.3/lib/llvm/bin/../../../include/hip/hip_bfloat16.h:41:2: error: ("Must define exactly one of __HIP_PLATFORM_AMD__ or __HIP_PLATFORM_NVIDIA__")***
   41 | #error ("Must define exactly one of __HIP_PLATFORM_AMD__ or __HIP_PLATFORM_NVIDIA__")***
      |  ^

[correaa]

I am lost, who (what part of the configuration) must define those?

[correaa]

for reference, this is the Github's Copilot diagnostics. I would appreciate help to understand how is this connected to the Multi update. It looks to me like a Cmake problem, but I don't know what to change.

Failing symptom

Compiler error in rocprim/hip headers: hip headers emit "Must define exactly one of HIP_PLATFORM_AMD or HIP_PLATFORM_NVIDIA" plus unknown identifiers like host and template errors in rocprim/functional.hpp.
This indicates the HIP platform macro is not being defined when compiling code that includes HIP/rocprim/thrust headers (e.g. SplinePot.cc). The build used amdclang++ and ROCm includes but the HIP platform macro wasn't present.

Root cause

rocprim / hip headers require exactly one of HIP_PLATFORM_AMD or HIP_PLATFORM_NVIDIA to be defined before including hip headers. When that macro is missing, many HIP-specific host/device qualifiers and symbols are undefined and parsing fails.
CI/ CMake isn't propagating the HIP platform definition into all targets that include these headers (or the CI environment didn't set HIP_PLATFORM). The CMake target platform_rocm_runtime (linked as hip::host) currently does not add a compile definition forcing the platform macro.

Immediate fixes (pick one)

CMake-based (recommended)

Add an INTERFACE compile definition to the ROCm platform runtime target so any target depending on it gets the macro defined.

Edit src/Platforms/ROCm/CMakeLists.txt and add a target_compile_definitions line after creating platform_rocm_runtime. Example patch:
Diff

12| add_library(platform_rocm_runtime INTERFACE)
13| target_link_libraries(platform_rocm_runtime INTERFACE hip::host)

• Ensure HIP platform macro is defined for headers that require it.

• Define AMD by default; if you build for NVIDIA set HIP_PLATFORM env to "nvidia"

• if(DEFINED ENV{HIP_PLATFORM} AND "$ENV{HIP_PLATFORM}" STREQUAL "nvidia")

• target_compile_definitions(platform_rocm_runtime INTERFACE HIP_PLATFORM_NVIDIA=1)

• else()

• target_compile_definitions(platform_rocm_runtime INTERFACE HIP_PLATFORM_AMD=1)

• endif()

  Rationale: this makes the macro available to any target that links to platform_rocm_runtime (the existing code already attaches platform_rocm_runtime to platform_rocm_LA). It also covers non-ROCm-specific targets that still include rocprim headers transitively.

  CI / environment workaround

  Export HIP_PLATFORM before CMake configure so the HIP providers and headers behave correctly:

In CI job (before cmake configure step) add:

export HIP_PLATFORM=amd or set CXXFLAGS/CMAKE_CXX_FLAGS to include -D__HIP_PLATFORM_AMD__:
CXXFLAGS="-D__HIP_PLATFORM_AMD__=1" (and reconfigure)

This is useful if you prefer not to change repository CMake or to quickly validate the fix in CI.

Target-specific compile definition (if you prefer minimal scope)

If only a few targets need the macro (e.g. targets that include thrust/rocprim), add target_compile_definitions for those concrete targets where headers are included. Example:

target_compile_definitions(some_target PRIVATE HIP_PLATFORM_AMD=1)

Testing and verification

Commit the CMake change and re-run CI.
If you choose the env workaround, re-run the CI job with HIP_PLATFORM=amd exported.
If errors persist, add diagnostic output in CMake to confirm which macro is being set and inspect compile command lines (e.g. enable CMake VERBOSE=1 / ninja -v) to confirm -D__HIP_PLATFORM_AMD__ appears in the compile command for the failing translation unit (SplinePot.cc).

Notes and cautions

If you actually build for NVIDIA HIP on some hosts, ensure only HIP_PLATFORM_NVIDIA is defined there, not both. The provided conditional uses the HIP_PLATFORM env var to distinguish; adjust to your environment or CI matrix as needed.
Defining the macro unconditionally for targets that never include HIP headers is usually harmless, but prefer defining it via the ROCm-specific target so it's only propagated where intended.
If find_package(HIP ...) in your top-level CMake sets a variable you can check instead of the environment variable (e.g. HIP_PLATFORM or HIP_RUNTIME detection), prefer checking that CMake variable.

Summary of recommended change (one-liner)

Add to src/Platforms/ROCm/CMakeLists.txt:

target_compile_definitions(platform_rocm_runtime INTERFACE HIP_PLATFORM_AMD=1)

(or the conditional snippet above) — then re-run CI. This will resolve the "Must define exactly one of HIP_PLATFORM_AMD or HIP_PLATFORM_NVIDIA" header errors and allow the compile to proceed.

[correaa]

ok, I found the problem. I found it very tricky to include "optionally" Thrust across platforms. I proposed a solution, let's see if it works (currently, GitHub interfaces are very sluggish)

[prckent]

Test this please

[prckent]

Test this please

[correaa]

ok, now that it works. I am going to make a release for QMCPACK.

BTW, the main repository for Multi is now develop.

[prckent]

Thanks Alfredo. It will be cleanest if you close this PR and then make a new one with the versioned release of multi.

[correaa]

ok, let's do that.