Skip to content

docs: sync API docs from website#71

Merged
linfangw merged 1 commit into
mainfrom
docs/sync-api-docs-26404205879
May 26, 2026
Merged

docs: sync API docs from website#71
linfangw merged 1 commit into
mainfrom
docs/sync-api-docs-26404205879

Conversation

@linfangw
Copy link
Copy Markdown
Contributor

Mirrors website-owned REST API, Cookbook, and OpenAPI docs after qveris-website release/test changed. Source run: https://github.com/WonderfulValley/qveris-website/actions/runs/26404205879.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenAPI specification and its generated TypeScript definitions, primarily adjusting internal source line references and refining the description of the provider categories endpoint to mention the shared provider catalog snapshot. Feedback highlights a security concern regarding the exposure of internal file paths and line numbers in the public schema via the x-qveris-source extension. Additionally, a consistency check is requested for the description of the /providers endpoint to align with the changes made to the categories endpoint.

"x-qveris-source": {
"file": "backend/routers/auth.py",
"line": 3150
"line": 3157
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The x-qveris-source extension exposes internal backend file paths and line numbers in the public API specification. This information leaks internal implementation details and directory structures to external consumers. Consider stripping these internal metadata fields (including x-qveris-response-model) during the generation or sync process for the public-facing schema.

],
"summary": "Get Provider Categories",
"description": "Get provider categories from the real API",
"description": "Get provider categories from the shared provider catalog snapshot.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description for /providers/categories has been updated to mention the 'shared provider catalog snapshot', but the /providers endpoint (line 2027) still refers to the 'real API'. If both endpoints now share the same data source, their descriptions should be updated consistently to avoid confusion for API consumers.

@linfangw linfangw merged commit d3a1160 into main May 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants