Qasm3 parametric circuit#152
Closed
Mayank447 wants to merge 10 commits into
Closed
Conversation
Mayank447
force-pushed
the
qasm3-parametric-circuit
branch
2 times, most recently
from
f004539 to
8495cdb
Compare
3 tasks
Mayank447
force-pushed
the
qasm3-parametric-circuit
branch
from
8495cdb to
a953dc1
Compare
Mayank447
force-pushed
the
qasm3-parametric-circuit
branch
from
4087f44 to
2161a87
Compare
Mayank447
force-pushed
the
qasm3-parametric-circuit
branch
from
cb0d122 to
990270c
Compare
Author
|
@doichanj I have implemented the stab function to get the parameter symbols. Please take a look. |
Member
|
Closing in favor of #159 Thanks @Mayank447 for the contribution anyway! If you would like to work on another issue, take a look at https://qisk.it/good-first-issues for a list of newcomer-friendly issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow Qiskit C++ to export qasm3 for parametrized circuits. As a suggestion it might be better to add a C-API extension to get all the circuit parameters (currently there is only an API to get number of parameters).
Details and comments
Essentially
to_qasm3method has been moved to a different file and linked to Circuit class via the implementation header file. The only major change is in to print the parameters declaration afterinclude stdgates.inc;as per QASM3 standard.Note: The implementation is mine but the tests were generated by Opus 4.6. I have verified the generated tests but its betters to properly review them for any edge case I missed.
Fixes #146