Refactor integration tests#2337
Conversation
| filename_not_valid_path = os.path.join(resources_path, filename_not_valid) | ||
|
|
||
|
|
||
| class TestFilesExecution: |
There was a problem hiding this comment.
both of these tests read and write COS files, so I'm pretty sure that they need storage access and belong in storage. Let me know if I'm mistaken.
There was a problem hiding this comment.
You are right but the test is about the execution, the COS is de indirect way to see if the execution gone right. I prioritized execution because is more specific.
There was a problem hiding this comment.
I thought the idea was to separate tests by what credentials they need to run, right? so if they need COS credentials it's different than if they don't, right @korgan00?
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
# Conflicts: # tests/integration/execution/test_jobs_execution.py
ElePT
left a comment
ElePT
left a comment
There was a problem hiding this comment.
After an offline discussion with @korgan00, we agreed that the current test distribution is a good first approach to the refactor. It could be improved by separating tests that require no credentials at all, but so far we are separating those that require running on actual fleets vs. not (can run only in simulation)
2 participants
Summary
Split integration tests into two folders depending on the resources that the test access.
One folder for function executions and another folder with access to databases and storages.
Details and comments