Merge pull request #1 from Liam-DeVoe/314-bug-flushing

try flushing 3.14 bug

Author: Liam-DeVoe

.github/workflows/main.yml

@@ -11,35 +11,29 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
-    name: Run tests with ${{ matrix.python-version }}
+    name: Run tests with ${{ matrix.python-version[0] }}
     strategy:
       fail-fast: false
       matrix:
-        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13', '3.13t', 'pypy-3.8']
+        python-version:
+          - ['3.9', '3.9']
+          - ['3.10', '3.10']
+          - ['3.11', '3.11']
+          - ['3.12', '3.12']
+          - ['3.13', '3.13']
+          - ['3.13t', '3.13t']
+          - ['3.14-dev', '3.14']
+          - ['3.14t-dev', '3.14t']
+          - ['pypy-3.9', 'pypy3.9']
     steps:
       - uses: actions/checkout@v4
-      - uses: astral-sh/setup-uv@v3
+      - uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version[0] }}
 
       - name: Install tox
         run: |
-          uv tool install \
-            --python-preference only-managed \
-            --python 3.13 \
-            tox \
-            --with tox-uv \
-            --with tox-gh
+          pip install tox
 
-      - name: Install Python
-        # We've installed Python 3.13 above already
-        if: matrix.python-version != '3.13'
-        run: uv python install --python-preference only-managed ${{ matrix.python-version }}
-
-      - name: Setup test suite
-        run: tox run -vv --notest --skip-missing-interpreters false
-        env:
-          TOX_GH_MAJOR_MINOR: ${{ matrix.python-version }}
-
-      - name: Run test suite
-        run: tox run --skip-pkg-install
-        env:
-          TOX_GH_MAJOR_MINOR: ${{ matrix.python-version }}
+      - name: Run test suite (${{ matrix.python-version[0] }})
+        run: tox -e ${{ matrix.python-version[1] }}

.gitignore

@@ -56,7 +56,6 @@ coverage.xml
 .pytest_cache/
 cover/
 *,cover
-.hypothesis/
 .pytest_cache
 
 # Translations

README.md

@@ -61,11 +61,30 @@ those fixtures are shared between threads.
 
 ## Features
 
-- Three global CLI flags:
+- Global CLI flags:
     - `--parallel-threads` to run a test suite in parallel
     - `--iterations` to run multiple times in each thread
     - `--skip-thread-unsafe` to skip running tests marked as or
       detected to be thread-unsafe.
+    - `--mark-warnings-as-unsafe` and `--mark-ctypes-as-unsafe`
+       to always skip running tests that use the `warnings` or
+       `ctypes` modules, respectively. These are useful if you are
+       adding support for Python 3.14 to a library that already
+       runs tests under pytest-run-parallel on Python 3.13 or
+       older.
+    - `--mark-hypothesis-as-unsafe`, to always skip runing tests that
+      use [hypothesis](https://github.com/hypothesisworks/hypothesis).
+      While newer version of Hypothesis are thread-safe, and versions
+      which are not are automatically skipped by `pytest-run-parallel`,
+      this flag is an escape hatch in case you run into thread-safety
+      problems caused by Hypothesis, or in tests that happen to use
+      hypothesis and were skipped in older versions of pytest-run-parallel.
+    - `--ignore-gil-enabled`, to ignore the RuntimeWarning generated
+      when the GIL is enabled at runtime on the free-threaded build
+      and run the tests despite the fact that the GIL is enabled.
+      This option has no effect if pytest is configured to treat warnings
+      as errors.
+
 
 - Three corresponding markers:
     - `pytest.mark.parallel_threads(n)` to mark a single test to run
@@ -80,6 +99,8 @@ those fixtures are shared between threads.
     - `num_parallel_threads`: The number of threads the test will run in
     - `num_iterations`: The number of iterations the test will run in
         each thread
+    - `thread_index`: An index for the test's current thread.
+    - `iteration_index`: An index for the test's current iteration.
 
 **Note**: It's possible to specify `--parallel-threads=auto` or
 `pytest.mark.parallel_threads("auto")` which will let
@@ -125,18 +146,24 @@ current design with `@pytest.mark.thread_unsafe` or
 `@pytest.mark.thread_unsafe(reason="...")`.
 
 The following functions and modules are known to be thread-unsafe and
-pytest-run-parallel will automatically not run tests using them in
+pytest-run-parallel will automatically skip running tests using them in
 parallel:
 
-- `pytest.warns`
-- `pytest.deprecated_call`
 - The pytest `capsys` fixture
 - The pytest `monkeypath` fixture
+
+The following fixtures are known to be thread-unsafe on Python 3.13 and older,
+or on 3.14 and newer if Python isn't configured correctly:
+
+- `pytest.warns`
+- `pytest.deprecated_call`
 - The pytest `recwarn` fixture
 - `warnings.catch_warnings`
 - `unittest.mock`
 - `ctypes`
-- Any test using [hypothesis](https://hypothesis.readthedocs.io/en/latest/).
+
+If an older version of `hypothesis` that is known to be thread-unsafe is
+installed, tests using `hypothesis` are skipped.
 
 Additionally, if a set of fixtures is known to be thread unsafe, tests
 that use them can be automatically marked as thread unsafe by declaring
@@ -237,6 +264,20 @@ Both modes of operations are supported simultaneously, i.e.,
 $ pytest -x -v --parallel-threads=5 test_file.py
 ```
 
+You can skip tests marked as or detected to be thread-unsafe by passing
+`--skip-thread-unsafe` in your pytest invocation. This is useful when running
+pytest-run-parallel under [Thread
+Sanitizer](https://clang.llvm.org/docs/ThreadSanitizer.html). Setting
+`--skip-thread-unsafe=True` will avoid unnecessarily running tests where thread
+sanitizer cannot detect races because the test is not parallelized.
+
+Older versions of pytest-run-parallel always marked tests using the `warnings`
+and `ctypes` modules as thread-unsafe, since both were not thread-safe until
+Python 3.14. If you are adding support for Python 3.14 and would like to
+continue marking tests that use `warnings` or `ctypes`, pass
+`--mark-warnings-as-unsafe` or `--mark-ctypes-as-unsafe`, respectively, in your
+`pytest` invocation.
+
 Additionally, `pytest-run-parallel` exposes the `num_parallel_threads`
 and `num_iterations` fixtures which enable a test to be aware of the
 number of threads that are being spawned and the number of iterations
@@ -252,12 +293,19 @@ def test_skip_if_parallel(num_parallel_threads):
     ...
 ```
 
-You can skip tests marked as or detected to be thread-unsafe by passing
-`--skip-thread-unsafe` in your pytest invocation. This is useful when running
-pytest-run-parallel under [Thread
-Sanitizer](https://clang.llvm.org/docs/ThreadSanitizer.html). Setting
-`--skip-thread-unsafe=True` will avoid unnecessarily running tests where thread
-sanitizer cannot detect races because the test is not parallelized.
+The `thread_index` and `iteration_index` fixtures are also avaliable, which enable
+tests to display different behavior between threads and iterations.
+
+```python
+# test_file.py
+import numpy as np
+
+def test_unique_rng_streams(thread_index):
+    # create an RNG stream with a seed that is deterministic
+    # but still unique to this thread
+    rng = np.random.default_rng(thread_index)
+    ...
+```
 
 Finally, the `thread_comp` fixture allows for parallel test debugging,
 by providing an instance of `ThreadComparator`, whose `__call__` method

RELEASE.md

@@ -1,9 +1,19 @@
 To release a new version of `pytest-run-parallel`:
 1. Update version in `pyproject.toml`, remove `-dev` suffix
-2. Make release commit using git add -A && git commit -m "chore(release): release vX.X.X"
-3. git tag -a vX.X.X -m "Release vX.X.X"
-4. Increment minor version and append the `-dev` suffix
-5. git add -A && git commit -m "chore: set development version to vY.Y.Y"
-6. git push && git push --tags
-7. Create a new release in GitHub and wait for package distribution to be
-uploaded to PyPi.
+2. Open PR with the version change
+3. After PR is merged, run git tag -a vX.X.X -m "Release vX.X.X"
+4. Create a new release in GitHub pointing to the new tag. Use autogenerated
+   release notes. Edit to remove any unnecessary stuff like the release PRs.
+   Wheels will be uploaded automatically by `.github/workflows/release.yml`.
+5. Increment minor version and append the `-dev` suffix in `pyproject.toml`
+6. Open PR with the version change
+7. Monitor [conda-forge feedstock](https://github.com/conda-forge/pytest-run-parallel-feedstock)
+   for anything that might be off in the auto-generated (and automerged) PR.
+
+For major releases consider the following manual testing steps before releasing
+1. Run test collection for the following projects which use pytest-run-parallel in CI
+   * SciPy
+   * CFFI
+   * pyyaml-ft
+
+The full tests are not necessary to run as most issues happen during AST parsing.

pyproject.toml

@@ -7,9 +7,9 @@ build-backend = "setuptools.build_meta"
 [project]
 name = "pytest-run-parallel"
 description = "A simple pytest plugin to run tests concurrently"
-version = "0.4.5-dev"
+version = "0.6.2-dev"
 readme = "README.md"
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 dependencies = [
     "pytest>=6.2.0",
 ]
@@ -28,7 +28,6 @@ classifiers = [
     "Topic :: Software Development :: Testing",
     "Operating System :: OS Independent",
     "Programming Language :: Python",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
@@ -53,7 +52,7 @@ psutil = [
 [dependency-groups]
 dev = [
     "pre-commit>=3.5.0",
-    "pytest-cov>=5.0.0",
+    "coverage[toml]>=7.5",
     "pytest-order>=1.3.0",
     "ruff>=0.7.2",
     "tox>=4.23.2",
@@ -66,26 +65,34 @@ exclude = ["docs/conf.py"]
 select = ["E4", "E7", "E9", "F", "I"]
 
 [tool.tox]
-env_list = ["py38", "py39", "py310", "py311", "py312", "py313", "py313t", "psutil", "pypy3", "ruff"]
+env_list = ["py39", "py310", "py311", "py312", "py313", "py313t", "psutil", "pypy3", "ruff"]
 
 [tool.tox.env_run_base]
 deps = [
     "pytest>=6.2.0",
-    "pytest-cov",
+    "coverage[toml]>=7.5",
     "pytest-order",
     "check-manifest",
-    "hypothesis",
+    "hypothesis>=6.135.33",
 ]
 commands = [
     [
+    "coverage",
+    "run",
+    "--source=pytest_run_parallel,tests",
+    "-m",
     "pytest",
+    "-W",
+    "error",
     "-v",
-    "--cov-report", "lcov",
-    "--cov", "src/pytest_run_parallel",
-    "--cov", "tests",
     "{posargs:tests}"
     ],
     [
+    "coverage",
+    "report",
+    "-m"
+    ],
+    [
     "check-manifest",
     "-u",
     "-v",
@@ -104,11 +111,10 @@ extras = ["psutil"]
 
 
 [tool.tox.gh.python]
-"3.8" = ["py38"]
 "3.9" = ["py39"]
 "3.10" = ["py310"]
 "3.11" = ["py311"]
 "3.12" = ["py312"]
 "3.13" = ["py313", "psutil"]
 "3.13t" = ["py313t"]
-"pypy-3.8" = ["pypy3"]
+"pypy-3.9" = ["pypy3"]