Skip analyzing doctests and add num_parallel_threads fixture everywhere (#90)

Author: lysnikolaou

src/pytest_run_parallel/plugin.py

@@ -4,6 +4,7 @@
 import threading
 import warnings
 
+import _pytest.doctest
 import _pytest.outcomes
 import pytest
 
@@ -142,6 +143,27 @@ def closure(*args, **kwargs):
 
 @pytest.hookimpl(trylast=True)
 def pytest_itemcollected(item):
+    if not hasattr(item, "obj"):
+        if not hasattr(item, "_parallel_custom_item"):
+            warnings.warn(
+                f"Encountered pytest item with type {type(item)} with no 'obj' "
+                "attribute, which is incompatible with pytest-run-parallel. "
+                f"Tests using {type(item)} will not run in a thread pool.\n"
+                "The pytest-run-parallel plugin only supports custom collection "
+                "tree objects that wrap Python functions stored in an attribute "
+                "named 'obj'.\n"
+                "Define a '_parallel_custom_item' attribute on the pytest item"
+                "instance or class to silence this warning.\n"
+                "If you do not want to use pytest-run-parallel, uninstall it from "
+                "your environment."
+            )
+        item.add_marker(pytest.mark.parallel_threads(1))
+        return
+
+    if isinstance(item, _pytest.doctest.DoctestItem):
+        item.add_marker(pytest.mark.parallel_threads(1))
+        return
+
     n_workers = get_num_workers(item.config, item)
     fixtures = getattr(item, "fixturenames", ())
 
@@ -164,23 +186,6 @@ def pytest_itemcollected(item):
         else:
             item.add_marker(pytest.mark.parallel_threads(1))
 
-    if not hasattr(item, "obj"):
-        if hasattr(item, "_parallel_custom_item"):
-            return
-        warnings.warn(
-            f"Encountered pytest item with type {type(item)} with no 'obj' "
-            "attribute, which is incompatible with pytest-run-parallel. "
-            f"Tests using {type(item)} will not run in a thread pool.\n"
-            "The pytest-run-parallel plugin only supports custom collection "
-            "tree objects that wrap Python functions stored in an attribute "
-            "named 'obj'.\n"
-            "Define a '_parallel_custom_item' attribute on the pytest item"
-            "instance or class to silence this warning.\n"
-            "If you do not want to use pytest-run-parallel, uninstall it from "
-            "your environment."
-        )
-        return
-
     skipped_functions = [
         x.split(".") for x in item.config.getini("thread_unsafe_functions")
     ]

tests/test_run_parallel.py

@@ -589,3 +589,31 @@ def test_parallel_2(num_parallel_threads):
             "*All tests were run in parallel! 🎉*",
         ]
     )
+
+
+def test_doctests_marked_thread_unsafe(pytester):
+    pytester.makepyfile("""
+    def test_parallel(num_parallel_threads):
+        assert num_parallel_threads == 10
+    """)
+
+    pytester.makefile(
+        ".txt",
+        """
+    hello this is a doctest
+    >>> x = 3
+    >>> x
+    3
+    >>> num_parallel_threads = getfixture("num_parallel_threads")
+    >>> num_parallel_threads
+    1
+    """,
+    )
+
+    result = pytester.runpytest("--parallel-threads=10", "-v")
+    result.stdout.fnmatch_lines(
+        [
+            "*::test_parallel PARALLEL PASSED*",
+            "*::test_doctests_marked_thread_unsafe.txt PASSED*",
+        ]
+    )