fix: add capteesys, capsysbinary, capfd and capfdbinary to thread-unsafe fixtures#157
Merged
Merged
Conversation
Collaborator
|
I think we want to include all the fixtures listed in the first sentence of this section of the pytest docs: https://docs.pytest.org/en/stable/how-to/capture-stdout-stderr.html#accessing-captured-output-from-a-test-function So, capsys, capteesys, capsysbinary, capfd, and capfdbinary. |
Contributor
Author
|
I'll add them |
mayeut
changed the title
capsysbinary to thread-unsafe fixturescapteesys, capsysbinary, capfd and capfdbinary to thread-unsafe fixtures
`capteesys` was introduced in pytest 8.4.0
Contributor
Author
|
I raised the minimum version of pytest to run tests as |
ngoldbaum
reviewed
Dec 14, 2025
ngoldbaum
left a comment
ngoldbaum
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! I noticed that there's a preexisting typo in the docs, monkeypatch is spelled monkeypath.
lysnikolaou
reviewed
Dec 18, 2025
lysnikolaou
left a comment
lysnikolaou
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @mayeut!
Only one comment regarding the change in pyproject.toml.
lysnikolaou
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capsysbinaryfixture is not thread safe, same ascapsys