Avoid crash for sybil doctests#174
Conversation
itamarst
left a comment
itamarst
left a comment
There was a problem hiding this comment.
Tested with original reproducer, it fixes the problem there too. Two minor changes, and then seems fine to merge.
| assert result.parseoutcomes()["warnings"] == 1 | ||
|
|
||
|
|
||
| def test_incompatible_test_item_2(pytester): |
There was a problem hiding this comment.
This test is almost identical to the next one in the file, so at first glance it's not clear how it differs. Eventually on third reading I noticed the self._parallel_custom_item = True in test_known_incompatible_test_item_doesnt_warn, but it took a while.
(I am, to be fair, extremely sleep deprived so not at my cognitive best, but perhaps that's a reasonable stand-in for "maintainer in the future who hasn't looked at the code in 12 months".)
It would therefore be helpful if this test and the next had docstrings explaining the specific behavior they are trying to check.
| "*::test_incompatible_item PASSED*", | ||
| ] | ||
| ) | ||
| assert result.parseoutcomes()["warnings"] == 1 |
There was a problem hiding this comment.
Might be useful to check the content of the warning.
|
Thanks for taking a look! |
2 participants
Fixes #172.