Use = as separator for the test run report#185
Merged
Conversation
Collaborator
|
Just to make it a little more clear for me, any chance you can make a before/after comparison for how the test output looks? I seriously doubt anyone depends on the character we're using here so if |
Member
Author
|
Before this change, the test summary looks like (truncated logs): After this change, this will look like: (The centering might be a little off, I did that manually) |
Collaborator
|
Makes sense to me. I'm just going to go ahead and merge this. I'd be really really surprised if anyone depended on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the parallel test run summary has been using
*as the separator, which feels a bit odd when browsing the full pytest summary, since the rest of the native section headers provided by pytest use=as the separator. This PR changes it to use=. Would this be fine?I checked the blame while opening this PR, and did not astutely find a reason as to why
*was chosen. Theterminalreporterwas introduced in c37a9ca with*and stayed in subsequent commits, was reorganised in 63ef3b1 to become a section, and kept the same character.So while
*makes it easier to visually distinguish this section in GitHub Actions CI/local terminal logs, I'm not sure if this was a deliberate design choice. Something for consideration, maybe...