Skip to content

Fix issue where string dtype singleton elsize was accidentally changed#73

Merged
peytondmurray merged 2 commits into
Quansight:mainfrom
peytondmurray:661-singleton-dtype-fix
Feb 20, 2026
Merged

Fix issue where string dtype singleton elsize was accidentally changed#73
peytondmurray merged 2 commits into
Quansight:mainfrom
peytondmurray:661-singleton-dtype-fix

Conversation

@peytondmurray
Copy link
Copy Markdown
Collaborator

@peytondmurray peytondmurray commented Feb 18, 2026

This fixes an issue where the numpy string/bytes dtype singletons were being modified by npyodbc. This happens in 2 places:

  • This can occur when coercing SQL types to string/bytes numpy dtypes using the target_dtypes kwarg
  • When reading binary column types (this is the case that prompted the original bug report)

A test was also added to catch this.

@peytondmurray peytondmurray merged commit 63edccd into Quansight:main Feb 20, 2026
19 of 25 checks passed
@peytondmurray peytondmurray deleted the 661-singleton-dtype-fix branch February 20, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant