Skip to content

Commit c42be2c

Browse files
mmckyclaude
andcommitted
Build strict: enable -W in ci.yml and publish.yml
Both builds carried `# TODO: Re-enable -W flag once all lectures are translated and warnings are resolved`. The precondition is already met: this edition has 26 of 26 lectures with a `_toc.yml` identical to source, so there are no untranslated lectures left to produce dangling cross-references. The case for strict is stronger than build hygiene. A translated edition carries the same code as its English source, so a warning here that does not appear upstream is evidence of a translation defect, not noise — which makes -W a translation-quality signal. It is also the last line of defence against a class of silent engine corruption. QuantEcon/action-translation#118 (a resync wrapped an entire 1,465-line document in a code fence and mis-derived its title from a Python tuple-unpacking line) and #119 (a `{raw} jupyter` directive argument stripped to `{raw}`) both reported success at run time, looked plausible in review, and surfaced weeks later only because a downstream repo built with -n -W. Without the flag this edition would merge that class of damage green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 40df73d commit c42be2c

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ jobs:
4242
- name: Build HTML
4343
shell: bash -l {0}
4444
run: |
45-
jb build lectures --path-output ./ -n --keep-going
46-
# TODO: Re-enable -W flag once all lectures are translated and warnings are resolved
45+
jb build lectures --path-output ./ -n -W --keep-going
4746
- name: Upload Execution Reports
4847
uses: actions/upload-artifact@v7
4948
if: failure()

.github/workflows/publish.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ jobs:
5656
- name: Build HTML
5757
shell: bash -l {0}
5858
run: |
59-
jb build lectures --path-output ./ -n --keep-going
60-
# TODO: Re-enable -W flag once all lectures are translated and warnings are resolved
59+
jb build lectures --path-output ./ -n -W --keep-going
6160
# Serves at the default Pages URL (no cname):
6261
# https://quantecon.github.io/lecture-python-programming.fr/
6362
- name: Deploy to GitHub Pages

0 commit comments

Comments
 (0)