Commit e74271a
* Migrate translation workflows to @v0 and the upstream review template
Moves review and rebase off the exact `@v0.16.1` pin onto the floating
`@v0` tag, per the pin policy settled in
QuantEcon/project-translation#9, and replaces the original
`translate setup` review workflow with the upstream template from
action-translation docs/user/tutorials/connect-existing.md.
This was the least-protected review workflow in the estate. It had no
`labeled` trigger, no concurrency group and no `permissions` block, so:
- a sync's `labeled` events started no review at all on that event type,
and nothing serialised concurrent runs against the same PR;
- v0.17.0's review dedupe deletes superseded comments, which needs
`pull-requests: write` — absent here, so dedupe could not work.
The pin was also two releases behind. v0.18.0 carries the fix for a
review-mode defect where a model response missing a criterion score
became NaN and rendered as an automatic FAIL on otherwise clean PRs
See QuantEcon/action-translation#102 — this repo is exposed to it today.
The job-level (not workflow-level) concurrency placement is deliberate
and field-verified: the group is entered only after the job's `if` has
passed, so a `labeled` event for 'automated' skips out without
cancelling the in-flight real review.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Rebase: also match resync/* branches (action-translation v0.18.1)
The rebase workflow only fired for `translation-sync-*` branches, which
the Action's sync mode creates. The CLI's `translate forward --github`
creates `resync/{stem}` branches, so merging one resync PR never
rebased its siblings — during a drift-recovery wave that leaves a stack
of open PRs whose bases go stale with every merge.
Fixed engine-side in action-translation v0.18.1, but the action-side
half is not sufficient on its own: this `if` gates whether the job runs
at all, and it runs before the action does. Both layers must list both
prefixes or the result is a job that never starts.
Brings this file in step with the upstream template as of that release.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent d5a4f5b commit e74271a
2 files changed
Lines changed: 40 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| |||
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
20 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
21 | 28 | | |
22 | 29 | | |
23 | | - | |
| 30 | + | |
| 31 | + | |
24 | 32 | | |
25 | 33 | | |
26 | 34 | | |
| |||
34 | 42 | | |
35 | 43 | | |
36 | 44 | | |
37 | | - | |
| 45 | + | |
38 | 46 | | |
39 | 47 | | |
40 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
2 | 7 | | |
3 | 8 | | |
4 | 9 | | |
5 | 10 | | |
6 | | - | |
| 11 | + | |
7 | 12 | | |
8 | 13 | | |
9 | 14 | | |
10 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
11 | 21 | | |
12 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
13 | 36 | | |
14 | 37 | | |
15 | 38 | | |
16 | 39 | | |
17 | 40 | | |
18 | | - | |
| 41 | + | |
19 | 42 | | |
20 | 43 | | |
21 | 44 | | |
| |||
0 commit comments