[kalman_2] Refactor simulate_workers for PEP8 compliance and code clarity#481
Merged
mmcky merged 1 commit intoQuantEcon:mainfrom Jul 21, 2025
Merged
[kalman_2] Refactor simulate_workers for PEP8 compliance and code clarity#481mmcky merged 1 commit intoQuantEcon:mainfrom
mmcky merged 1 commit intoQuantEcon:mainfrom
Conversation
Contributor
|
thank you for this PR @suda-yuga I really like these changes. @HumphreyYang I think using |
mmcky
approved these changes
Jul 21, 2025
Member
Thanks @mmcky! I agree. I think unpacking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
simulate_workersfunction to follow Python best practices and enhance readability. The main changes include:isinstance(..., type(None))withis Nonechecks for clarity.diff == Truein favor of direct boolean evaluation.is Noneinstead of== NoneforNonecomparisons.[y_hat_t[i]] = worker.G @ x_hatwith scalar extraction using.item().The matrix multiplication returns a single-element array, so using
.item()explicitly converts it to a scalar value, improving code clarity and avoiding the need for list unpacking.