Add translation review and rebase workflows (Phase 0 Track B)#100
Merged
Conversation
Copied from lecture-intro.zh-cn (Track A wiring, includes the fr-pattern review guards and v0.17.0 review dedupe) with source-repo pointed at QuantEcon/lecture-python.myst. Requires the ANTHROPIC_API_KEY org secret to be extended to this repo. Part of Phase 0 Track B, QuantEcon/lecture-python.myst#947. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Adds GitHub Actions workflows to support automated translation maintenance in this translated repository: one workflow posts an AI-assisted quality review on translation PRs, and another automatically rebases remaining translation-sync PRs after one is merged.
Changes:
- Add
review-translations.ymlto runQuantEcon/action-translationinreviewmode for PRs labeledaction-translation, with per-PR concurrency and deduping permissions. - Add
rebase-translations.ymlto runQuantEcon/action-translationinrebasemode when atranslation-sync-*PR is merged, with global concurrency to prevent overlapping rebases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/review-translations.yml | Introduces a PR-triggered translation review job using QuantEcon/action-translation@v0, gated by the action-translation label and job-level concurrency. |
| .github/workflows/rebase-translations.yml | Introduces an auto-rebase job for translation-sync PRs after merge to reduce conflicts across concurrently-open sync PRs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
+20
| if: > | ||
| contains(github.event.pull_request.labels.*.name, 'action-translation') && | ||
| (github.event.action != 'labeled' || github.event.label.name == 'action-translation') |
Comment on lines
+21
to
+23
| if: > | ||
| github.event.pull_request.merged == true && | ||
| startsWith(github.event.pull_request.head.ref, 'translation-sync-') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of QuantEcon/lecture-python.myst#947. Adds
review-translations.ymlandrebase-translations.yml, copied from lecture-intro.zh-cn's Track A wiring (fr-pattern review guards, v0.17.0 review dedupe, job-level concurrency) with source-repo pointed at QuantEcon/lecture-python.myst.Blocked on a secret: the ANTHROPIC_API_KEY org secret is not yet visible to this repo (QUANTECON_SERVICES_PAT is). Extending it needs org admin — until then the review/rebase jobs will fail at the API-key step.
Known limitation: the review workflow reviews resync PRs only once a release containing action-translation#108 ships and
@v0moves — the current v0.17.0@v0still lacks #104's metadata fallback, so this wave's resync PRs get their review from the local sweep instead (see the wave report).🤖 Generated with Claude Code