Skip to content

[action-translation] resync: mccall_model_with_separation.md#134

Merged
mmcky merged 3 commits into
mainfrom
resync/mccall_model_with_separation
Jul 19, 2026
Merged

[action-translation] resync: mccall_model_with_separation.md#134
mmcky merged 3 commits into
mainfrom
resync/mccall_model_with_separation

Conversation

@mmcky

@mmcky mmcky commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Forward Resync: mccall_model_with_separation.md

Source: QuantEcon/lecture-python.mystlectures/mccall_model_with_separation.md
Source commit: 0bfcac8
This PR resyncs the translation to match the current source document.

Reason: The Chinese translation reflects an entirely different, older version of the lecture (using Numba/jitclass instead of JAX, different variable naming like v/h/d vs v_e/v_u, different code structure, no GPU admonition include, missing 'Overview' library imports like jax, different figure directives using local PNG files instead of glue, missing the 'the model' overview intro paragraphs about capital loss/investment framing in same wording, missing exercise reproduction details matching new JAX code). This is a substantially outdated translation missing significant content updates (JAX-based implementation, updated model derivation with v_e/v_u notation, updated Bellman equation derivations, updated code cells, glue-based figures) present in the source. This constitutes major CONTENT_CHANGES throughout, not just stylistic differences.

Changes

Whole-file resync applied. The entire document was resynced in a single pass.


Created by action-translation forward resync

Copilot AI review requested due to automatic review settings July 18, 2026 08:18
@mmcky mmcky added action-translation-sync Auto-created by action-translation resync Forward resync labels Jul 18, 2026
@netlify

netlify Bot commented Jul 18, 2026

Copy link
Copy Markdown

Deploy Preview for astonishing-narwhal-a8fc64 ready!

Name Link
🔨 Latest commit 8d7c035
🔍 Latest deploy log https://app.netlify.com/projects/astonishing-narwhal-a8fc64/deploys/6a5c192aceda660008e8cd3f
😎 Deploy Preview https://deploy-preview-134--astonishing-narwhal-a8fc64.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR forward-resyncs the Chinese translation of mccall_model_with_separation.md to match the current upstream lecture version, updating both the narrative and the code (moving from the older Numba-based approach to the newer JAX-based approach, plus glue-based figures and updated derivations).

Changes:

  • Resynced the entire lecture content to the current upstream structure/notation (e.g., v_e / v_u, updated Bellman equations, updated exposition).
  • Replaced the legacy implementation with a JAX-based implementation (including scalar-equation simplification and jax.jit solver).
  • Switched figure handling from static PNGs to myst_nb.glue + {glue:figure} directives and added translation metadata.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
lectures/mccall_model_with_separation.md Whole-document resync to upstream lecture: updated text, math, JAX code cells, and glue-based figures.
.translate/state/mccall_model_with_separation.md.yml Records the resync state (source SHA, date, model, mode, etc.).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +48 to +49
```{include} _admonition/gpu.md
```
Comment on lines +335 to +339
v_u_next = T_u(model, v_u, v_e)
v_e_next = T_e(model, v_u, v_e)
error_u = jnp.max(jnp.abs(v_u_next - v_u))
error_e = jnp.max(jnp.abs(v_e_next - v_e))
error = jnp.max(jnp.array([error_u, error_e]))
fig, ax = plt.subplots()
ax.plot(w, v_e, 'b-', lw=2, alpha=0.7, label='$v_e$')
ax.plot(w, [h] * len(w), 'g-', lw=2, alpha=0.7, label='$h$')
ax.set_xlim(min(w), max(w))
Comment on lines +393 to +394
w_bar_full = compute_reservation_wage_full(model)
print(f"保留工资(完整模型):{w_bar_full:.4f}")
Comment on lines +585 to +589
w_bar_simplified = compute_reservation_wage(model)
print(f"保留工资(简化方法):{w_bar_simplified:.4f}")
print(f"保留工资(完整模型):{w_bar_full:.4f}")
print(f"差异:{abs(w_bar_simplified - w_bar_full):.6f}")
```
@mmcky mmcky added the action-translation PRs created by QuantEcon/action-translation label Jul 18, 2026
@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request July 18, 2026 10:29 Inactive
The resynced file keeps Chinese plot labels but reverted the import
cell to the source's exact form, losing the Source Han Serif setup -
Chinese in figures would render as missing glyphs. Residual #107
class found in the merge review; applied wave-wide.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown

✅ Translation Quality Review

Verdict: PASS | Model: claude-sonnet-5 | Date: 2026-07-19


📝 Translation Quality

Criterion Score
Accuracy 9/10
Fluency 9/10
Terminology 9/10
Formatting 9/10
Overall 9/10

Summary: This is a high-quality, accurate resync translation that faithfully preserves the mathematical content, code structure, and technical terminology of the English source. Minor discrepancies include a jupytext_version mismatch and additional font-setup code not present in the source, but these do not affect the substantive translation quality of the modified content. Mathematical notation, LaTeX equations, and cross-reference labels (e.g., {eq}, {doc}, {ref}) are preserved accurately throughout. Technical terminology such as '贝尔曼方程', '保留工资', '延续值/继续价值', '离职率' is applied consistently and matches standard economics translation conventions. Code blocks and comments are fully and naturally translated, including docstrings, without altering code logic or variable names. The translation maintains a natural academic register in Chinese while accurately conveying nuanced explanations of the McCall search-and-separation model.

Suggestions:

  • Front matter: The English source's jupytext_version is '1.17.2' but the translation shows '1.17.1' — minor version mismatch that should be synced to match source exactly.
  • Code cell imports section: The translation adds extra font-configuration lines (matplotlib font setup for Chinese characters) not present in the English source. While this is a common and reasonable practice for Chinese-language notebooks, it constitutes an addition beyond the source content and could be flagged as deviation from a strict resync if not intended as a standard boilerplate addition.

🔍 Diff Quality

Check Status
Scope Correct
Position Correct
Structure Preserved
Heading-map Correct
Overall 10/10

Summary: The target document was correctly resynced to match the new English source structure, content, and translation metadata.


This review was generated automatically by action-translation review mode.

@github-actions
github-actions Bot temporarily deployed to pull request July 18, 2026 11:33 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request July 19, 2026 00:47 Inactive
@mmcky
mmcky merged commit a543f54 into main Jul 19, 2026
7 checks passed
@mmcky
mmcky deleted the resync/mccall_model_with_separation branch July 19, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action-translation PRs created by QuantEcon/action-translation action-translation-sync Auto-created by action-translation resync Forward resync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants