Align build environment with the English source (supersedes the env half of #97)#165
Merged
Conversation
environment.yml copied from lecture-python.myst (anaconda 2026.06, jupyter-book <2.0, quantecon-book-theme 0.21.0, sphinx-tojupyter 0.6.0 and current sphinx-* pins) so the resynced 2026-era lecture code builds against the same stack the source executes under. Adds the source's nb_merge_streams setting to _config.yml. Supersedes the environment half of #97 (which pinned anaconda 2025.12 / theme 0.15.1 — current in December, seven months behind now). Part of Phase 0 Track B, QuantEcon/lecture-python.myst#947. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Aligns the Chinese lecture build stack with the current lecture-python.myst English source so the 2026-era resync wave can build and execute under the same dependency set.
Changes:
- Add
nb_merge_streams: trueto the JupyterBook/Sphinx config to match upstream execution/output handling. - Update
environment.ymlto anaconda 2026.06 and refresh/pin the upstream Sphinx/JupyterBook/theme-related pip dependencies (including ajupyter-bookversion range).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lectures/_config.yml |
Adds nb_merge_streams: true under sphinx.config to match upstream notebook output behavior. |
environment.yml |
Updates the conda/pip environment pins to match the upstream build environment (anaconda 2026.06 + updated Sphinx/JupyterBook ecosystem pins). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 18, 2026
mmcky
added a commit
that referenced
this pull request
Jul 18, 2026
#97) (#166) * CI hardening: strict builds, conda dependabot, missing wald_dec_rule.png Carries forward the pieces of #97 that #165 did not supersede: - jb build gains '-n -W --keep-going' in cache/ci/publish workflows, matching the English source repos' strict-build convention - dependabot watches the conda ecosystem (jupyter-book pinned <2.0, python constrained by the anaconda distribution) - wald_dec_rule.png copied from the source repo (referenced by wald_friedman_2 but absent here - a warning today, an error under -W) Dropped from #97 as obsolete: the lecture-code fixes (regenerated by the Track B resync wave or applied directly to its branches) and the ogm.py tweak (optgrowth_fast was removed in #99). Part of Phase 0 Track B, QuantEcon/lecture-python.myst#947. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Fix the two main-content strict-build breaks: mix_model import, cass_fiscal ref mix_model kept a CJK font-config block without the mpl import it needs (same class as the five wave-branch fixes; mix_model was skipped by the wave so the pre-existing bug stayed on main). cass_fiscal's note pointed {doc} at a document that never existed; replaced with the wave branch's exact {ref}`growth_model` sentence so the resync PR merges cleanly over it. newton_method's two iref_ambiguous warnings are NOT patched here: old main lacks the local anchors, and the resync PR (#140) adds them - merging #140 resolves those warnings without conflict-prone edits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copies lecture-python.myst's current
environment.yml(anaconda 2026.06, jupyter-book>=1.0.4post1,<2.0, quantecon-book-theme 0.21.0, sphinx-tojupyter 0.6.0, current sphinx-* pins) and adds the source'snb_merge_streams: trueto_config.yml. The Track B resync wave (#101–#164) brings lecture code to the source's 2026-era state — it should build against the same stack the source executes under, not the 2025.06 pins on main.Relationship to #97: that PR was current when opened in December (anaconda 2025.12 / theme 0.15.1) but is now seven months behind the source. This PR supersedes its environment/config changes; #97's remaining pieces (dependabot config, workflow action-version bumps) are untouched here and can still be merged or cherry-picked — Matt's call whether to rebase #97 down to those or close it.
Not touched:
environment-cn.yml— no workflow references it (all three useenvironment.yml); consider deleting it separately as dead config.After merging: dispatch the cache workflow so the execution cache rebuilds under the new environment, then re-run wave-PR checks.
🤖 Generated with Claude Code