CI hardening: strict builds, conda dependabot, missing figure (succeeds #97)#166
Merged
Conversation
Carries forward the pieces of #97 that #165 did not supersede: - jb build gains '-n -W --keep-going' in cache/ci/publish workflows, matching the English source repos' strict-build convention - dependabot watches the conda ecosystem (jupyter-book pinned <2.0, python constrained by the anaconda distribution) - wald_dec_rule.png copied from the source repo (referenced by wald_friedman_2 but absent here - a warning today, an error under -W) Dropped from #97 as obsolete: the lecture-code fixes (regenerated by the Track B resync wave or applied directly to its branches) and the ogm.py tweak (optgrowth_fast was removed in #99). Part of Phase 0 Track B, QuantEcon/lecture-python.myst#947. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Hardens the documentation build CI for lecture-python.zh-cn by enabling “strict build” behavior (treat warnings as errors, nitpicky mode, keep going) across the main build workflows and adding Dependabot coverage for the conda environment to keep build dependencies current and controlled.
Changes:
- Add
-n -W --keep-goingtojb build lecturesin CI, cache, and publish workflows to fail builds on warnings while still reporting multiple issues. - Add a Dependabot
condaecosystem entry at repo root with ignores forjupyter-book >= 2.0and allpythonupdates (leaving Python pinned by the Anaconda distribution).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/publish.yml | Enables strict JupyterBook/Sphinx build flags for publish builds. |
| .github/workflows/ci.yml | Enables strict build flags for the primary CI workflow. |
| .github/workflows/cache.yml | Enables strict build flags for the cache rebuild workflow. |
| .github/dependabot.yml | Adds conda Dependabot updates with targeted ignore rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…fiscal ref
mix_model kept a CJK font-config block without the mpl import it needs
(same class as the five wave-branch fixes; mix_model was skipped by the
wave so the pre-existing bug stayed on main). cass_fiscal's note pointed
{doc} at a document that never existed; replaced with the wave branch's
exact {ref}`growth_model` sentence so the resync PR merges cleanly over
it. newton_method's two iref_ambiguous warnings are NOT patched here:
old main lacks the local anchors, and the resync PR (#140) adds them -
merging #140 resolves those warnings without conflict-prone edits.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curated successor to #97, per Matt: everything that PR carried which #165 didn't supersede.
Included:
-n -W --keep-goingon the three build workflows (the English source repos' strict-build convention — this is what would have caught the five missing-import execution bugs the wave sweep just fixed by hand); a conda dependabot ecosystem entry (jupyter-book held<2.0, python constrained by anaconda);wald_dec_rule.pngcopied from the source (referenced by wald_friedman_2, missing here — warning today, error under-W).Dropped as obsolete: #97's lecture-code fixes — back_prop's jax API and house_auction's identifier were regenerated correctly by the resync wave; the five missing
import matplotlib as mplbugs were fixed directly on their wave branches today; the ogm.py tweak targets optgrowth_fast, removed in #99.Note: this PR's own CI is the strictness test — if current content produces any warning under
-W, this build goes red and names it, which is the point. Merge after the wave lands, or before with the knowledge that wave PRs then must be warning-clean too. #97 can be closed once this is in.🤖 Generated with Claude Code