Rebase: also match resync/* branches (action-translation v0.18.1) - #186
Merged
Conversation
The rebase workflow only fired for `translation-sync-*` branches, which
the Action's sync mode creates. The CLI's `translate forward --github`
creates `resync/{stem}` branches, so merging one resync PR never
rebased its siblings — during a drift-recovery wave that leaves a stack
of open PRs whose bases go stale with every merge.
Fixed engine-side in action-translation v0.18.1, but the action-side
half is not sufficient on its own: this `if` gates whether the job runs
at all, and it runs before the action does. Both layers must list both
prefixes or the result is a job that never starts.
Brings this file in step with the upstream template as of that release.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the translation rebase GitHub Actions workflow so it runs for both Action-created translation-sync-* branches and CLI-created resync/* branches, aligning this repo with the upstream action-translation template behavior.
Changes:
- Expanded the workflow job
if:condition to match bothtranslation-sync-*andresync/*branch prefixes. - Updated workflow comments to document the two supported branch naming schemes and why both must be handled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The bare 'forward --github' is not a runnable invocation — the binary is 'translate'. Caught by Copilot on lecture-python-programming.fr#15; applied estate-wide so the copies stay in step with the upstream template, which gets the same fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings this repo's rebase workflow in step with the upstream template as of action-translation v0.18.1.
Why the engine fix alone was not enough
The rebase workflow only fired for
translation-sync-*branches, which the Action's sync mode creates. The CLI'stranslate forward --githubcreatesresync/{stem}branches — so merging one resync PR never rebased its siblings. During a drift-recovery wave that leaves a stack of open PRs whose bases go stale with every merge, each re-enqueued by hand. Observed on the 69-PRlecture-python.zh-cnTrack B wave.That was fixed engine-side in v0.18.1 (#121, closing #115) — but the prefix turned out to be enforced in three places, and this workflow
ifis one of them. It gates whether the job runs at all, and it runs before the action does. So a repo can be pinned@v0, pick up the engine fix automatically, and still never rebase a resync PR, because the job never starts.Both layers must list both prefixes. This PR is the workflow half.
Verification status
Per the harness-first policy, this is staged but should not merge until the fix is validated end-to-end on the
test-translation-syncharness. The rebase path has never been exercised end-to-end, and the original defect was invisible precisely because its failure mode is silence — a job that skips looks identical to a job with nothing to do.Part of Stage 1 follow-up; see QuantEcon/project-translation#9.
🤖 Generated with Claude Code