🌐 [translation-sync] Tom's July 25 edits of two suites of new lectures#207
Open
mmcky wants to merge 36 commits into
Open
🌐 [translation-sync] Tom's July 25 edits of two suites of new lectures#207mmcky wants to merge 36 commits into
mmcky wants to merge 36 commits into
Conversation
mmcky
added
action-translation
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
| Criterion | Score |
|---|---|
| Accuracy | 8/10 |
| Fluency | 8/10 |
| Terminology | 8/10 |
| Formatting | 8/10 |
| Overall | 8/10 |
Summary: 整体翻译质量较高，专业术语翻译准确且与参考术语表基本一致，数学公式和MyST/Markdown格式保存完整，未发现破坏编译的语法错误。主要问题集中在phillips_lost_conquest.md文档中导入代码块被无端添加了与英文原文不符的字体设置代码，这属于对源内容的擅自改动，建议予以修正。其余各讲座（如phillips_two_stories.md中的记号说明表、phillips_drifts_volatilities.md中的先验部分）翻译流畅准确，仅有个别术语缩写展开建议等细微改进空间。 数学公式、LaTeX代码块与MyST指令在翻译中均完整保留，未出现格式破坏或语法错误 专业术语翻译总体准确一致，如“自我确认均衡”“归纳假说”“逃逸动态”“递归最小二乘法”等核心概念在多篇讲座中保持统一 长难句的处理较为得当，学术语域把握准确，未出现明显的翻译腔或生硬直译 标题、代码单元格标签（mystnb figure caption等）与练习/解答结构完整保留，符合Jupyter Book的编译要求 中文标点符号使用规范，全角标点与英文行内代码/公式之间的空格处理基本符合中文技术文档排版惯例
Suggestions:
- [major · terminology] lectures/phillips_lost_conquest.md — 导入部分: 翻译中在导入代码块里插入了额外的字体设置代码（import matplotlib as mpl 等 i18n 相关行），这些内容不在英文原文的代码块中，属于对代码内容的擅自修改，可能影响与源文档的一致性和可复现性。 → 移除代码块中新增的字体设置行，仅保留与英文原文一致的导入语句：import matplotlib.pyplot as plt\nimport numpy as np\nimport pandas as pd\nimport datetime\nfrom pandas_datareader import data as web\nfrom scipy.linalg import solve_discrete_are
- [minor · fluency] lectures/phillips_two_stories.md — 关于记号的说明: 术语对照表中"记号"一词使用得当，但部分表格内文字（如"人力财富"等术语对照示例不在此文档中）未见问题；此处未发现实质性错误，仅提示表格内技术符号说明基本准确。
- [minor · terminology] lectures/phillips_drifts_volatilities.md — 先验: "似不相关回归（SUR）"的翻译准确，但在其余部分"SUR"缩写多次单独出现而未展开，虽然可从上下文推断，仍建议首次出现处补充全称以保持一致性。 → 在首次出现"SUR"时明确标注"似不相关回归（Seemingly Unrelated Regression, SUR）"
- [nit · fluency] lectures/prospects_bounded_rationality.md — 为何计量经济学家未曾回礼: 该部分整体翻译流畅、准确，术语处理得当（如"滋扰参数"对应nuisance parameter，"有限理性"对应bounded rationality），是本次PR中翻译质量较高的章节之一。
🔍 Diff Quality
| Check | Status |
|---|---|
| Scope Correct | ❌ |
| Position Correct | ❌ |
| Structure Preserved | ✅ |
| Heading-map Correct | ✅ |
| Overall | 5/10 |
Summary: The translation appears to cover the correct set of files superficially, but the combined text format prevents reliable verification of per-file position, structure, and heading-map correctness.
Issues:
- The English source diff shows 16 files (mix of new bounded-rationality lectures and edits to existing phillips_* lectures), but the target 'After' content provided is a translation of an entirely different/unrelated set of documents (bounded_rationality, exchange_rate_learning, genetic_classifier, marimon_mcgrattan_sargent, phillips_credible_policies, prospects_bounded_rationality, plus modified phillips_* files) - the actual translated content does correspond file-by-file to the change list, so scope superficially matches by filename, but content ordering in the presented merged document does not follow a verifiable per-file structure alignment
- The 'Before' and 'After' full-text blobs are concatenations of many files without clear delimiters matching the 16 changed files exactly, making it impossible to confirm each file's internal section order matches 1:1
- Several new files (bounded_rationality.md, exchange_rate_learning.md, genetic_classifier.md, marimon_mcgrattan_sargent.md, phillips_credible_policies.md, prospects_bounded_rationality.md) appear as translations, which is expected for 'added' files, but their translation frontmatter heading-maps need verification against actual headings used in-body - several headings like 'The knowledge that rational expectations imputes', 'Sargent's formulation of bounded rationality' etc. are present in heading-map and appear to correspond to actual subheadings, which is good, but this cannot be fully cross-verified against the diff line numbers provided
- Given the complexity and the fact that the diff summary (file list with +/- counts) does not clearly align with the massive combined text blob, full verification of position and structure correctness for each of the 16 files is not reliably possible from the given data
This review was generated automatically by action-translation review mode.
There was a problem hiding this comment.
Pull request overview
This automated translation-sync PR brings in a new “Bounded Rationality in Macroeconomics” lecture suite (plus its wrap-up) and extends/refreshes the Phillips Curve Tradeoffs sequence, updating the zh-cn lecture set and JupyterBook TOC to match upstream lecture-python.myst.
Changes:
- Added new Bounded Rationality lectures (e.g., exchange rate learning, genetic/classifier systems, prospects) and their translation state files.
- Updated multiple Phillips Curve lectures with new sections (e.g., notation note), index directives, formatting/notation adjustments, and additional figures/captions.
- Updated
lectures/_toc.ymlto include the new Bounded Rationality part and the newphillips_credible_policieschapter.
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lectures/bounded_rationality.md | New translated lecture added for the Bounded Rationality suite. |
| .translate/state/bounded_rationality.md.yml | Translation sync state for bounded_rationality.md. |
| lectures/olg_adaptive_money.md | New translated lecture added for the Bounded Rationality suite. |
| .translate/state/olg_adaptive_money.md.yml | Translation sync state for olg_adaptive_money.md. |
| lectures/exchange_rate_learning.md | New translated lecture added (includes executable code cells). |
| .translate/state/exchange_rate_learning.md.yml | Translation sync state for exchange_rate_learning.md. |
| lectures/genetic_classifier.md | New translated lecture added (includes executable code cells). |
| .translate/state/genetic_classifier.md.yml | Translation sync state for genetic_classifier.md. |
| lectures/marimon_mcgrattan_sargent.md | New translated lecture added for the Bounded Rationality suite. |
| .translate/state/marimon_mcgrattan_sargent.md.yml | Translation sync state for marimon_mcgrattan_sargent.md. |
| lectures/prospects_bounded_rationality.md | New translated wrap-up lecture added for the Bounded Rationality suite. |
| .translate/state/prospects_bounded_rationality.md.yml | Translation sync state for prospects_bounded_rationality.md. |
| lectures/phillips_credible_policies.md | New translated Phillips lecture added and referenced by others. |
| .translate/state/phillips_credible_policies.md.yml | Translation sync state for phillips_credible_policies.md. |
| lectures/phillips_two_stories.md | Updated overview content + added notation section and index entry. |
| .translate/state/phillips_two_stories.md.yml | Translation sync state updated for phillips_two_stories.md. |
| lectures/phillips_credibility.md | Updated text/formatting and figure metadata; minor code/comment tweaks. |
| .translate/state/phillips_credibility.md.yml | Translation sync state updated for phillips_credibility.md. |
| lectures/phillips_adaptive.md | Updated text/formatting, figures, and added index entry. |
| .translate/state/phillips_adaptive.md.yml | Translation sync state updated for phillips_adaptive.md. |
| lectures/phillips_misspecified.md | Updated text/formatting, figures, and added index entry. |
| .translate/state/phillips_misspecified.md.yml | Translation sync state updated for phillips_misspecified.md. |
| lectures/phillips_self_confirming.md | Updated text/formatting, figures, and added index entry. |
| .translate/state/phillips_self_confirming.md.yml | Translation sync state updated for phillips_self_confirming.md. |
| lectures/phillips_learning.md | Updated text/formatting, figures, and added index entry; exercise text reshaped. |
| .translate/state/phillips_learning.md.yml | Translation sync state updated for phillips_learning.md. |
| lectures/phillips_escaping_nash.md | Updated text/formatting, figures, and added index entry. |
| .translate/state/phillips_escaping_nash.md.yml | Translation sync state updated for phillips_escaping_nash.md. |
| lectures/phillips_priors.md | Updated text/formatting, figures, and added index entry. |
| .translate/state/phillips_priors.md.yml | Translation sync state updated for phillips_priors.md. |
| lectures/phillips_lost_conquest.md | Updated text/formatting, figures, and added index entry; code refactor for η. |
| .translate/state/phillips_lost_conquest.md.yml | Translation sync state updated for phillips_lost_conquest.md. |
| lectures/phillips_drifts_volatilities.md | Updated text/formatting; data-loading approach changed (see comments). |
| .translate/state/phillips_drifts_volatilities.md.yml | Translation sync state updated for phillips_drifts_volatilities.md. |
| lectures/_toc.yml | TOC updated to add new Bounded Rationality part + new Phillips chapter. |
Comments suppressed due to low confidence (2)
lectures/phillips_drifts_volatilities.md:357
- Use the local
data_pathvariable (defined in the earlier setup cell) rather than the externaldata_urlwhen loading the dataset for transformations.
data = prepare_data(data_url)
lectures/phillips_drifts_volatilities.md:2076
- This later read should use the same local
data_pathas the main dataset load so builds don’t depend on network access.
cs_sample = pd.read_csv(data_url)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+320
to
+322
| ```{code-cell} ipython3 | ||
| for name, e, l in [("experiment 1", e1, l1), ("experiment 2", e2, l2)]: | ||
| print(f"{name}: e → {e[-1]:.4f}, s → {s1[-1][0]:.3f}, λ → {l[-1][0]:.3f}") |
Comment on lines
320
to
324
| def prepare_data(source, ordering=('i', 'u', 'pi')): | ||
| """Transform a quarterly table and construct the VAR data.""" | ||
| if isinstance(source, (str, Path)): | ||
| if isinstance(source, str): | ||
| table = pd.read_csv(source) | ||
| else: |
Comment on lines
+110
to
+114
| data_url = ( | ||
| 'https://raw.githubusercontent.com/QuantEcon/lecture-python.myst/' | ||
| 'main/lectures/_static/lecture_specific/phillips_drifts_volatilities/' | ||
| 'NEWQDATA.csv' | ||
| ) |
This was referenced Jul 27, 2026
Contributor
Author
|
Error: translation produced 2 error(s); branch left untouched: Error processing lectures/genetic_classifier.md: Error: structural parity check failed for lectures/genetic_classifier.md:
You may need to manually resolve conflicts or run |
…he undelivered lecture, backfill the bib Three fixes, all consequences of the run that produced this PR being partial (see QuantEcon/action-translation#222). 1. Merge conflict on olg_adaptive_money. Both this PR and #208 created lectures/olg_adaptive_money.md and its state file from scratch. Keep main's version, which #208 landed: it is built from the newer source SHA (a4fbd86) and so carries the pip-install cell, and it matches the English source structurally at 62 fenced directives to 62. This branch's copy predates #1006 and is one directive short. 2. learning_approximation was never delivered. The run committed a _toc.yml entry for it but failed structural parity on the file, so the entry pointed at nothing and the build failed with "toctree contains reference to nonexisting document", plus four unknown-document cross-references. Drop the _toc.yml entry and remove the four {doc} references from bounded_rationality.md and genetic_classifier.md. The lecture stays untranslated and is tracked separately; the references return when it is seeded. 3. quant-econ.bib was missing 21 keys cited by the new lectures, fatal under -W. Replace the file wholesale from the English source rather than backfilling the cited subset — the target bib is a strict subset of source (0 target-only keys), this is the third such backfill, and the wholesale copy also closes the three latent keys that are not yet cited. Mechanism tracked in QuantEcon/action-translation#117. Verified: all 355 citations resolve, every _toc.yml entry has a file, every lecture is reachable from _toc.yml, no dangling {doc} references. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Translation Sync
This PR contains automated translations from QuantEcon/lecture-python.myst.
Source PR
#1001 - Tom's July 25 edits of two suites of new lectures
Files Added
lectures/bounded_rationality.md.translate/state/bounded_rationality.md.ymllectures/exchange_rate_learning.md.translate/state/exchange_rate_learning.md.ymllectures/genetic_classifier.md.translate/state/genetic_classifier.md.ymllectures/marimon_mcgrattan_sargent.md.translate/state/marimon_mcgrattan_sargent.md.ymllectures/olg_adaptive_money.md.translate/state/olg_adaptive_money.md.ymllectures/phillips_credible_policies.md.translate/state/phillips_credible_policies.md.ymllectures/prospects_bounded_rationality.md.translate/state/prospects_bounded_rationality.md.ymlFiles Updated
lectures/phillips_adaptive.md.translate/state/phillips_adaptive.md.ymllectures/phillips_credibility.md.translate/state/phillips_credibility.md.ymllectures/phillips_drifts_volatilities.md.translate/state/phillips_drifts_volatilities.md.ymllectures/phillips_escaping_nash.md.translate/state/phillips_escaping_nash.md.ymllectures/phillips_learning.md.translate/state/phillips_learning.md.ymllectures/phillips_lost_conquest.md.translate/state/phillips_lost_conquest.md.ymllectures/phillips_misspecified.md.translate/state/phillips_misspecified.md.ymllectures/phillips_priors.md.translate/state/phillips_priors.md.ymllectures/phillips_self_confirming.md.translate/state/phillips_self_confirming.md.ymllectures/phillips_two_stories.md.translate/state/phillips_two_stories.md.ymllectures/_toc.ymlDetails
This PR was created automatically by the translation action.