Point the learning_approximation references at the English edition#209
Open
mmcky wants to merge 1 commit into
Open
Point the learning_approximation references at the English edition#209mmcky wants to merge 1 commit into
mmcky wants to merge 1 commit into
Conversation
Repairing #207 removed four {doc} references to learning_approximation, because the sync run that produced that PR named the lecture in _toc.yml without ever writing it, and a reference to a document this edition does not have fails the strict build. Removing them was the wrong repair. The passages that cited the lecture still make the argument that depends on it, and a reader following the bounded-rationality series now has no route to the content at all. Intersphinx gives that route back. `intermediate:` is already configured in lectures/_config.yml against https://python.quantecon.org/, and the lecture is live there and present in its objects.inv, so the target resolves. Each link is marked （英文版）so it is clear the destination is untranslated, and the rendered link text is the English title, which makes that visible before the reader clicks. learning_approximation is still absent from this edition's _toc.yml, which is correct — it has no translation yet. Once it is seeded these four go back to plain local references; that is tracked separately. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR restores four previously removed references to learning_approximation by converting them into intersphinx {doc} links targeting the English (python.quantecon.org) edition, avoiding fatal missing-local-doc errors while preserving navigability for readers.
Changes:
- Restored one series-contents bullet link in
bounded_rationality.mdas{doc}→intermediate:learning_approximationwith an explicit “（英文版）” marker. - Restored three in-text links in
genetic_classifier.mdto the same intersphinx target, also marked “（英文版）”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lectures/bounded_rationality.md | Re-adds the missing learning_approximation reference as an intersphinx {doc} link in the series list. |
| lectures/genetic_classifier.md | Restores three narrative references to learning_approximation via intersphinx {doc} links to the English edition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairing #207 removed four
{doc}references tolearning_approximation. That was the wrong repair, and this puts them back as intersphinx links to the English edition.Why they were removed
The sync run that produced #207 named
learning_approximationin_toc.ymlbut never wrote the file — it failed the structural parity check, so the engine correctly refused to commit corrupt output (action-translation#156, #118). A{doc}reference to a document this edition does not have is fatal under-n -W, so the four references had to go for the PR to build.Why that was wrong
The passages still make the argument that depends on that lecture — least-squares learners finding an equilibrium, the duality between a learning economy and an equilibrium computation. Removing the links left the prose intact but severed the reader's route to the content, and a reader working through the bounded-rationality series had no way to reach it at all.
What this does
intermediate:is already configured inlectures/_config.ymlagainsthttps://python.quantecon.org/, and the lecture is live there (HTTP 200) and present in itsobjects.inv, so the target resolves at build time.bounded_rationality.mdgenetic_classifier.mdEach is marked （英文版）so the destination being untranslated is stated rather than discovered, and because the target is cross-project the rendered link text is the English title — which makes it visible before the reader clicks.
learning_approximationremains absent from this edition's_toc.yml, which is correct: it has no translation yet, and adding a ToC entry for a file that does not exist is precisely what broke #207.Follow-up
Once the lecture is seeded here, these four revert to plain local
{doc}references. Tracked separately — the seeding is blocked on action-translation#118, for which this lecture is the estate's cheapest deterministic reproducer.🤖 Generated with Claude Code