Skip to content

Commit 9641215

Browse files
mmckyclaude
andauthored
chore(deps): clear Dependabot security alerts (#385)
* chore(deps): clear Dependabot security alerts Bumps transitive dev dependencies via npm audit fix and upgrades two direct devDependencies whose patched versions required a major bump: - css-minimizer-webpack-plugin: ^7.0.2 → ^8.0.0 (clears serialize-javascript RCE/DoS advisories GHSA-5c6j-r48x-rmvq, GHSA-qj8w-gfj5-8c6v) - sass: ^1.94.2 → ^1.99.0 (clears immutable prototype-pollution advisory GHSA-wf6x-7x77-mvgw) `npm audit` now reports 0 vulnerabilities. All affected packages are dev/build-time only; no runtime/shipped code is changed. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * ci: bump Node to 20 for css-minimizer-webpack-plugin@8 engine requirement css-minimizer-webpack-plugin@8 and serialize-javascript@7 require Node >= 20. Bumps sphinx-theme-builder's nodeenv pin from 18.18.0 to 20.18.0 and the matching setup-node version across CI/docs/update-snapshots workflows. Without this, the editable install fails with 'ReferenceError: crypto is not defined' inside serialize-javascript. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * ci: bump .nvmrc and contributor docs to Node 20.18.0 Completes the Node 20 migration flagged by Copilot review on PR #385. Aligns .nvmrc, CONTRIBUTING.md, and docs/developer/setup.md with the sphinx-theme-builder node-version pin and the CI setup-node version. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 50be9e4 commit 9641215

9 files changed

Lines changed: 188 additions & 113 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
- name: Setup Node.js
4444
uses: actions/setup-node@v6
4545
with:
46-
node-version: '18'
46+
node-version: '20'
4747
cache: 'npm'
4848
- name: Install Playwright
4949
run: |

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- name: Set up Node.js
3535
uses: actions/setup-node@v6
3636
with:
37-
node-version: "18"
37+
node-version: "20"
3838
cache: "npm"
3939

4040
- name: Install Node.js dependencies and build assets

.github/workflows/update-snapshots.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
- name: Setup Node.js
6363
uses: actions/setup-node@v6
6464
with:
65-
node-version: '18'
65+
node-version: '20'
6666
cache: 'npm'
6767

6868
- name: Install Playwright
@@ -169,7 +169,7 @@ jobs:
169169
- name: Setup Node.js
170170
uses: actions/setup-node@v6
171171
with:
172-
node-version: '18'
172+
node-version: '20'
173173
cache: 'npm'
174174

175175
- name: Install Playwright

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18.18.0
1+
20.18.0

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Thank you for your interest in contributing to the QuantEcon Book Theme! This do
1616
### Prerequisites
1717

1818
- Python 3.12 or higher
19-
- Node.js 18.18.0 or higher (see `.nvmrc`)
19+
- Node.js 20.18.0 or higher (see `.nvmrc`)
2020
- Git
2121

2222
### Initial Setup

docs/developer/setup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Set up a local development environment for `quantecon-book-theme`.
55
## Prerequisites
66

77
- **Python 3.12 or newer**
8-
- **Node.js 18.18.0 or newer** — for compiling SCSS/JS assets with webpack
8+
- **Node.js 20.18.0 or newer** — for compiling SCSS/JS assets with webpack
99
- **Git**
1010

1111
## Initial Setup

package-lock.json

Lines changed: 178 additions & 103 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@
99
"devDependencies": {
1010
"@playwright/test": "^1.49.0",
1111
"css-loader": "^7.1.2",
12-
"css-minimizer-webpack-plugin": "^7.0.2",
12+
"css-minimizer-webpack-plugin": "^8.0.0",
1313
"dedent": "^1.7.0",
1414
"html-webpack-plugin": "^5.6.5",
1515
"mini-css-extract-plugin": "^2.9.4",
16-
"sass": "^1.94.2",
16+
"sass": "^1.99.0",
1717
"sass-loader": "^16.0.6",
1818
"webpack": "^5.103.0",
1919
"webpack-cli": "^6.0.1",

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ requires = ["sphinx-theme-builder >= 0.2.0a7"]
33
build-backend = "sphinx_theme_builder"
44

55
[tool.sphinx-theme-builder]
6-
node-version = "18.18.0"
6+
node-version = "20.18.0"
77
theme-name = "quantecon_book_theme"
88
additional-compiled-static-assets = [
99
"locales/"

0 commit comments

Comments
 (0)