Take review comments about signals into account.

Author: HaudinFlorence

src/bluetooth-extension/index.ts

@@ -94,7 +94,7 @@ const BluetoothSidebarPlugin: JupyterFrontEndPlugin<void> = {
           ]
         }).then(async result => {
           if (result.button.accept) {
-            bluetoothManager.deviceTypeRegistry.itemsList.forEach(
+            bluetoothManager.deviceTypeRegistry.deviceTypes.forEach(
               async item => {
                 if (item.deviceType === result.value) {
                   await bluetoothManager.connect(item);
@@ -160,7 +160,7 @@ export class DropDownRegistry
     this._selectList = document.createElement('select');
     this.node.appendChild(this._selectList);
     this.registry = registry;
-    registry.itemsList.forEach(item => {
+    registry.deviceTypes.forEach(item => {
       const option = document.createElement('option');
       option.value = item.deviceType;
       option.text = item.deviceType;

src/bluetooth/BluetoothManager.ts

@@ -241,65 +241,65 @@ export namespace BluetoothManager {
   }
 
   export class DeviceTypeRegistry implements IDeviceTypeRegistry {
-    private _deviceTypeRegistry: Array<IDeviceTypeRegistryItem>;
-    private _registeredByAPlugin: Signal<
-      this,
-      BluetoothManager.DeviceTypeRegistry
-    >;
-
-    public registryItem: IDeviceTypeRegistryItem;
     constructor() {
-      this._deviceTypeRegistry = [];
-      this._registeredByAPlugin = new Signal<
+      this._deviceTypes = [];
+      this._added = new Signal<
         this,
-        BluetoothManager.DeviceTypeRegistry
+        IDeviceTypeRegistryItem
       >(this);
     }
 
     add(registryItem: IDeviceTypeRegistryItem) {
-      this._deviceTypeRegistry.push(registryItem);
+      this._deviceTypes.push(registryItem);
+      this._added.emit(registryItem)
     }
-    get itemsList(): Array<IDeviceTypeRegistryItem> {
-      return this._deviceTypeRegistry;
+
+    get deviceTypes(): IDeviceTypeRegistryItem[] {
+      return this._deviceTypes;
     }
-    get registeredByAPlugin(): Signal<
+
+    get added(): Signal<
       this,
-      BluetoothManager.DeviceTypeRegistry
+      IDeviceTypeRegistryItem
     > {
-      return this._registeredByAPlugin;
+      return this._added;
     }
+
+    private _deviceTypes: Array<IDeviceTypeRegistryItem>;
+    private _added: Signal<
+      this,
+      IDeviceTypeRegistryItem
+    >;
+
+    public registryItem: IDeviceTypeRegistryItem;
   }
 }
 
-/**
- * Interface for the bluetooth manager.
- */
-export interface IBluetoothManager {
-  removeAllDevices(Devices: Array<BluetoothManager.Device>): void;
-  connect(registryItem: IDeviceTypeRegistryItem): any;
-  disconnect(device: BluetoothManager.Device): void;
-  deviceListChanged: Signal<BluetoothManager, Array<BluetoothManager.Device>>;
-  get deviceList(): Array<BluetoothManager.Device>;
-  get deviceTypeRegistry(): BluetoothManager.DeviceTypeRegistry;
-}
+  /**
+   * Interface for the bluetooth manager.
+   */
+  export interface IBluetoothManager {
+    removeAllDevices(Devices: Array<BluetoothManager.Device>): void;
+    connect(registryItem: IDeviceTypeRegistryItem): any;
+    disconnect(device: BluetoothManager.Device): void;
+    deviceListChanged: Signal<BluetoothManager, Array<BluetoothManager.Device>>;
+    get deviceList(): Array<BluetoothManager.Device>;
+    get deviceTypeRegistry(): BluetoothManager.DeviceTypeRegistry;
+  }
 
-export interface IDeviceTypeRegistryItem {
-  deviceType: string;
-  factory: (
-    native: BluetoothDevice
-  ) => Promise<BluetoothManager.Device | undefined>;
-  options: IDeviceOptions;
-}
+  export interface IDeviceTypeRegistryItem {
+    deviceType: string;
+    factory: (
+      native: BluetoothDevice
+    ) => Promise<BluetoothManager.Device | undefined>;
+    options: IDeviceOptions;
+  }
 
-export interface IDeviceTypeRegistry {
-  add: (registryItem: IDeviceTypeRegistryItem) => void;
-  get deviceTypes(): IDeviceTypeRegistryItem[];
-  get registeredByAPlugin(): Signal<
-    IDeviceTypeRegistry,
-    BluetoothManager.DeviceTypeRegistry
-  >;
-}
+  export interface IDeviceTypeRegistry {
+    add: (registryItem: IDeviceTypeRegistryItem) => void;
+    get deviceTypes(): IDeviceTypeRegistryItem[];
+  }
 
-export const IBluetoothManager = new Token<IBluetoothManager>(
-  '@jupyterlab/bluetooth:manager'
-);
+  export const IBluetoothManager = new Token<IBluetoothManager>(
+    '@jupyterlab/bluetooth:manager'
+  )

src/movehub-extension/index.ts

@@ -57,12 +57,12 @@ const MoveHubRegisterPlugin: JupyterFrontEndPlugin<void> = {
   ): void => {
     console.log('JupyterLab move-hub-register plugin is activated!');
     bluetoothManager.deviceTypeRegistry.add(movehubRegistryItem);
-    bluetoothManager.deviceTypeRegistry.registeredByAPlugin.emit(
-      bluetoothManager.deviceTypeRegistry
-    );
-    console.warn(
-      `New item from category ${movehubRegistryItem} is added to the registry.`
-    );
+    bluetoothManager.deviceTypeRegistry.added.connect(
+      async (sender, movehubRegistryItem) => {
+        console.warn(
+          `New item from category ${movehubRegistryItem.deviceType} is added to the deviceType registry.`
+        );
+      })
   }
 };