Skip to content

Parse reference solutions and evaluation criteria#16

Merged
brichet merged 5 commits into
QuantStack:mainfrom
Yahiewi:metadata
Jul 9, 2026
Merged

Parse reference solutions and evaluation criteria#16
brichet merged 5 commits into
QuantStack:mainfrom
Yahiewi:metadata

Conversation

@Yahiewi

@Yahiewi Yahiewi commented Jul 6, 2026

Copy link
Copy Markdown
Member

This PR implements decoding of encrypted reference solutions and parsing grading criteria from cell metadata to guide the AI tutor's feedback.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Binder 👈 Launch a Binder on branch Yahiewi/jupyter-ai-tutor/metadata

@Yahiewi Yahiewi mentioned this pull request Jul 6, 2026
@brichet brichet added the enhancement New feature or request label Jul 6, 2026

@brichet brichet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Yahiewi, I left a few comments.

Comment thread examples/matplotlib_exercices.ipynb Outdated
Comment thread src/index.ts Outdated
Comment thread src/utils.ts
/**
* Decodes a ROT13 encoded string.
*/
export function decodeRot13(str: string): string {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary ? We can probably keep the solution in plain text.
Otherwise we should really encrypt it using a passphrase, but this involve more complexity for now.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was something that was mentioned during the last meeting and can be found in the codimd document. I think the idea isn't necessarily to have encryption as ROT13 can be easily decoded, but to at least make it so inspecting the metadata doesn't directly give you the answer, while keeping things simple (not using any actual secure encryption).
image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's keep it for now then.

Comment thread src/utils.ts
Comment thread src/model.ts Outdated
@brichet brichet mentioned this pull request Jul 8, 2026
@Yahiewi

Yahiewi commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

Thanks @brichet for the reviews!
I updated the PR to address all your comments. For the ROT13 encryption thing, let me know if you think we should keep it as is now or if you prefer something else.

@brichet

brichet commented Jul 9, 2026

Copy link
Copy Markdown
Member

Thanks @Yahiewi, it works well.

Can you remove the useless description parameter in other function, now that the full message content is build in the frontend ?

description?: string,

description = body.get("description", "")

@Yahiewi

Yahiewi commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

Thanks @Yahiewi, it works well.

Can you remove the useless description parameter in other function, now that the full message content is build in the frontend ?

description?: string,

description = body.get("description", "")

Done. Thanks for the review, this looks good to go now.

@brichet brichet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Failing test is not related, jupyter-server/jupyter_releaser#659.

@brichet brichet merged commit 680f319 into QuantStack:main Jul 9, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants