Add drives to the filebrowser#5
Closed
HaudinFlorence wants to merge 8 commits into
Closed
Conversation
|
|
HaudinFlorence
force-pushed
the
display_selected_drives_in_filebrowser
branch
from
8d188ec to
3e335b4
Compare
…with the default file browser and the added drive one.
HaudinFlorence
force-pushed
the
display_selected_drives_in_filebrowser
branch
4 times, most recently
from
0949308 to
519065a
Compare
…ddDrivesPlugin and moved hard coded inputs mimicking backend side inputs , outside from the plugins and methods.
HaudinFlorence
force-pushed
the
display_selected_drives_in_filebrowser
branch
from
519065a to
762b483
Compare
fcollonval
reviewed
Nov 13, 2023
| toolbarRegistry, | ||
| settingRegistry, | ||
| FILE_BROWSER_FACTORY, | ||
| FILE_BROWSER_PLUGIN_ID, |
Contributor
There was a problem hiding this comment.
This should match the id of this plugin. I strongly advice you to use that constant as the id to avoid mistake here.
Member
Author
There was a problem hiding this comment.
To be fair I don't understand this point because it seems that FILE_BROWSER_PLUGIN_ID is refering to a plugin ID but then if a plugin name is given there, the following error message appears in the console:
jlab_core.96e0941fd34af0e81382.js?v=96e0941fd34af0e81382:1 Failed to load toolbar items for factory FileBrowser from @jupyter/drives:add-drives Error: Schema not found: /home/florence/micromamba/envs/new-jupyter-drives-dev/share/jupyter/lab/schemas/@jupyter/drives/add-drives.json
at Function.create (jlab_core.96e0941fd34af0e81382.js?v=96e0941fd34af0e81382:1:1272526)
at async a.fetch
It is a settings json file in the schemadirectory that seems expected
fcollonval
reviewed
Nov 13, 2023
| if (settingRegistry) { | ||
| setToolbar( | ||
| driveBrowser, | ||
| createToolbarFactory( |
Contributor
There was a problem hiding this comment.
For this to work you need to add a property toolbar in the setting JSON schema file like for the default browser:
https://github.com/jupyterlab/jupyterlab/blob/1c1058cc4933a4c67d10bc46927e59365aff9aaa/packages/filebrowser-extension/schema/widget.json#L55
HaudinFlorence
force-pushed
the
display_selected_drives_in_filebrowser
branch
4 times, most recently
from
53300ba to
3dc1c2b
Compare
Add logics to add the content of the drive to the filebrowser when adding a drive in the dialog.
HaudinFlorence
force-pushed
the
display_selected_drives_in_filebrowser
branch
3 times, most recently
from
19db95c to
41e8774
Compare
…nterface, when picking a drive by its name in the list of available drives. Add a toolbar to all the drive filebrowsers.
HaudinFlorence
force-pushed
the
display_selected_drives_in_filebrowser
branch
from
41e8774 to
becd51b
Compare
HaudinFlorence
force-pushed
the
display_selected_drives_in_filebrowser
branch
from
269613b to
60fb2b5
Compare
HaudinFlorence
force-pushed
the
display_selected_drives_in_filebrowser
branch
from
a1fa360 to
5cb95bc
Compare
Create a BreadCrumbsLayout to enable to have the breadcrumbs inside the AccordionPanel title section
HaudinFlorence
force-pushed
the
display_selected_drives_in_filebrowser
branch
from
5cb95bc to
2e46f8a
Compare
…multidrivesbrowser.ts, dirlisting.ts -> drivelisting.ts. Restore in index.ts a proper logics to add the content of an added driveBrowser to the multidrives browser when a drive is selected and added in the dialog.
HaudinFlorence
force-pushed
the
display_selected_drives_in_filebrowser
branch
from
c2f1eeb to
60c8eec
Compare
Member
|
Closing this as it is outdated. Thanks for the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logics to display selected drives to the filebrowser.