Skip to content

Commit 8719847

Browse files
authored
Merge branch 'main' into inline
2 parents c4f135b + 2cf6a39 commit 8719847

69 files changed

Lines changed: 355 additions & 320 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/chore.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Chore
22
on:
3-
pull_request:
3+
pull_request_target:
44
branches: [main]
55
types: [opened, reopened, edited, synchronize]
66
push:
@@ -13,7 +13,7 @@ concurrency:
1313
jobs:
1414
check-pr-title:
1515
name: Check PR Title
16-
if: github.event_name == 'pull_request'
16+
if: github.event_name == 'pull_request_target'
1717
runs-on: ubuntu-latest
1818
permissions:
1919
contents: read
@@ -51,16 +51,16 @@ jobs:
5151
delete: true
5252

5353
release-drafter:
54-
name: ${{ github.event_name == 'pull_request' && 'Assign Labels' || 'Draft Release' }}
54+
name: ${{ github.event_name == 'pull_request_target' && 'Assign Labels' || 'Draft Release' }}
5555
runs-on: ubuntu-latest
5656
permissions:
5757
contents: write
5858
pull-requests: write
5959
steps:
60-
- name: ${{ github.event_name == 'pull_request' && 'Assign labels' || 'Update release draft' }}
60+
- name: ${{ github.event_name == 'pull_request_target' && 'Assign labels' || 'Update release draft' }}
6161
uses: release-drafter/release-drafter@v6
6262
with:
63-
disable-releaser: ${{ github.event_name == 'pull_request' }}
63+
disable-releaser: ${{ github.event_name == 'pull_request_target' }}
6464
disable-autolabeler: ${{ github.event_name == 'push' }}
6565
env:
6666
GITHUB_TOKEN: ${{ github.token }}

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,4 @@ jobs:
5353
uses: codecov/codecov-action@v5
5454
with:
5555
files: ./coverage.xml
56+
token: ${{ secrets.CODECOV_TOKEN }}

dataframely/_base_collection.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class Metadata:
8585
members: dict[str, MemberInfo] = field(default_factory=dict)
8686
filters: dict[str, Filter] = field(default_factory=dict)
8787

88-
def update(self, other: Self):
88+
def update(self, other: Self) -> None:
8989
self.members.update(other.members)
9090
self.filters.update(other.filters)
9191

@@ -98,7 +98,7 @@ def __new__(
9898
namespace: dict[str, Any],
9999
*args: Any,
100100
**kwargs: Any,
101-
):
101+
) -> CollectionMeta:
102102
result = Metadata()
103103
for base in bases:
104104
result.update(mcs._get_metadata_recursively(base))

dataframely/_base_schema.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class Metadata:
5858
columns: dict[str, Column] = field(default_factory=dict)
5959
rules: dict[str, Rule] = field(default_factory=dict)
6060

61-
def update(self, other: Self):
61+
def update(self, other: Self) -> None:
6262
self.columns.update(other.columns)
6363
self.rules.update(other.rules)
6464

@@ -71,7 +71,7 @@ def __new__(
7171
namespace: dict[str, Any],
7272
*args: Any,
7373
**kwargs: Any,
74-
):
74+
) -> SchemaMeta:
7575
result = Metadata()
7676
for base in bases:
7777
result.update(mcs._get_metadata_recursively(base))

dataframely/_compat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77

88
class _DummyModule: # pragma: no cover
9-
def __init__(self, module: str):
9+
def __init__(self, module: str) -> None:
1010
self.module = module
1111

1212
def __getattr__(self, name: str) -> Any:

dataframely/_filter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
class Filter(Generic[C]):
1313
"""Internal class representing logic for filtering members of a collection."""
1414

15-
def __init__(self, logic: Callable[[C], pl.LazyFrame]):
15+
def __init__(self, logic: Callable[[C], pl.LazyFrame]) -> None:
1616
self.logic = logic
1717

1818

dataframely/_rule.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@
1212
class Rule:
1313
"""Internal class representing validation rules."""
1414

15-
def __init__(self, expr: pl.Expr):
15+
def __init__(self, expr: pl.Expr) -> None:
1616
self.expr = expr
1717

1818

1919
class GroupRule(Rule):
2020
"""Rule that is evaluated on a group of columns."""
2121

22-
def __init__(self, expr: pl.Expr, group_columns: list[str]):
22+
def __init__(self, expr: pl.Expr, group_columns: list[str]) -> None:
2323
super().__init__(expr)
2424
self.group_columns = group_columns
2525

dataframely/collection.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,7 @@ def collect_all(self) -> Self:
505505

506506
# ---------------------------------- PERSISTENCE --------------------------------- #
507507

508-
def write_parquet(self, directory: Path):
508+
def write_parquet(self, directory: Path) -> None:
509509
"""Write the members of this collection to Parquet files in a directory.
510510
511511
This method writes one Parquet file per member into the provided directory.
@@ -597,7 +597,7 @@ def _init(cls, data: Mapping[str, FrameType], /) -> Self:
597597
return out
598598

599599
@classmethod
600-
def _validate_input_keys(cls, data: Mapping[str, FrameType], /):
600+
def _validate_input_keys(cls, data: Mapping[str, FrameType], /) -> None:
601601
actual = set(data)
602602

603603
missing = cls.required_members() - actual

dataframely/columns/_mixins.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def validation_rules(self, expr: pl.Expr) -> dict[str, pl.Expr]:
8383
class IsInMixin(Generic[U], Base):
8484
"""Mixin to use for types implementing "is in"."""
8585

86-
def __init__(self, *, is_in: Sequence[U] | None = None, **kwargs: Any):
86+
def __init__(self, *, is_in: Sequence[U] | None = None, **kwargs: Any) -> None:
8787
super().__init__(**kwargs)
8888
self.is_in = is_in
8989

dataframely/columns/decimal.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,9 @@ def _sample_unchecked(self, generator: Generator, n: int) -> pl.Series:
148148
# --------------------------------------- UTILS -------------------------------------- #
149149

150150

151-
def _validate(value: decimal.Decimal, precision: int | None, scale: int, name: str):
151+
def _validate(
152+
value: decimal.Decimal, precision: int | None, scale: int, name: str
153+
) -> None:
152154
exponent = value.as_tuple().exponent
153155
if not isinstance(exponent, int):
154156
raise ValueError(f"Encountered 'inf' or 'NaN' for `{name}`.")

0 commit comments

Comments
 (0)