Skip to content

Commit b3d136e

Browse files
authored
test: Remove warnings emitted in tests (#4)
1 parent b24e904 commit b3d136e

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

tests/column_types/test_float.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def test_validate_min(
8383
lf = pl.LazyFrame({"a": [1, 2, 3, 4, 5]})
8484
actual = evaluate_rules(lf, rules_from_exprs(column.validation_rules(pl.col("a"))))
8585
expected = pl.LazyFrame(valid)
86-
assert_frame_equal(actual.select(expected.columns), expected)
86+
assert_frame_equal(actual.select(expected.collect_schema().names()), expected)
8787

8888

8989
@pytest.mark.parametrize("column_type", FLOAT_COLUMN_TYPES)
@@ -102,7 +102,7 @@ def test_validate_max(
102102
lf = pl.LazyFrame({"a": [1, 2, 3, 4, 5]})
103103
actual = evaluate_rules(lf, rules_from_exprs(column.validation_rules(pl.col("a"))))
104104
expected = pl.LazyFrame(valid)
105-
assert_frame_equal(actual.select(expected.columns), expected)
105+
assert_frame_equal(actual.select(expected.collect_schema().names()), expected)
106106

107107

108108
@pytest.mark.parametrize("column_type", FLOAT_COLUMN_TYPES)
@@ -157,7 +157,7 @@ def test_validate_range(
157157
lf = pl.LazyFrame({"a": [1, 2, 3, 4, 5]})
158158
actual = evaluate_rules(lf, rules_from_exprs(column.validation_rules(pl.col("a"))))
159159
expected = pl.LazyFrame(valid)
160-
assert_frame_equal(actual.select(expected.columns), expected)
160+
assert_frame_equal(actual.select(expected.collect_schema().names()), expected)
161161

162162

163163
@pytest.mark.parametrize("inf", [np.inf, -np.inf, float("inf"), float("-inf")])
@@ -176,7 +176,9 @@ def test_validate_allow_inf_nan(inf: Any, nan: Any):
176176
column = dy.Float(allow_inf_nan=True)
177177
lf = pl.LazyFrame({"a": pl.Series([inf, 2.0, nan, 4.0, 5.0])})
178178
actual = evaluate_rules(lf, rules_from_exprs(column.validation_rules(pl.col("a"))))
179-
assert len(actual.columns) == 0, "There should be no validation rules"
179+
assert len(actual.collect_schema().names()) == 0, (
180+
"There should be no validation rules"
181+
)
180182

181183

182184
def test_sample_unchecked_min_0():

tests/columns/test_rules.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,4 @@ def test_nullability_rule(column_type: type[Column]):
4040
lf = pl.LazyFrame({"a": [None]}, schema={"a": column.dtype})
4141
actual = evaluate_rules(lf, rules_from_exprs(column.validation_rules(pl.col("a"))))
4242
expected = pl.LazyFrame({"nullability": [False]})
43-
assert_frame_equal(actual.select(expected.columns), expected)
43+
assert_frame_equal(actual.select(expected.collect_schema().names()), expected)

0 commit comments

Comments
 (0)