Skip to content

test: Remove warnings emitted in tests #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oliver Borchert (borchero) merged 1 commit into from
Apr 19, 2025
Merged

test: Remove warnings emitted in tests #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/column_types/test_float.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def test_validate_min(
lf = pl.LazyFrame({"a": [1, 2, 3, 4, 5]})
actual = evaluate_rules(lf, rules_from_exprs(column.validation_rules(pl.col("a"))))
expected = pl.LazyFrame(valid)
assert_frame_equal(actual.select(expected.columns), expected)
assert_frame_equal(actual.select(expected.collect_schema().names()), expected)


@pytest.mark.parametrize("column_type", FLOAT_COLUMN_TYPES)
Expand All @@ -102,7 +102,7 @@ def test_validate_max(
lf = pl.LazyFrame({"a": [1, 2, 3, 4, 5]})
actual = evaluate_rules(lf, rules_from_exprs(column.validation_rules(pl.col("a"))))
expected = pl.LazyFrame(valid)
assert_frame_equal(actual.select(expected.columns), expected)
assert_frame_equal(actual.select(expected.collect_schema().names()), expected)


@pytest.mark.parametrize("column_type", FLOAT_COLUMN_TYPES)
Expand Down Expand Up @@ -157,7 +157,7 @@ def test_validate_range(
lf = pl.LazyFrame({"a": [1, 2, 3, 4, 5]})
actual = evaluate_rules(lf, rules_from_exprs(column.validation_rules(pl.col("a"))))
expected = pl.LazyFrame(valid)
assert_frame_equal(actual.select(expected.columns), expected)
assert_frame_equal(actual.select(expected.collect_schema().names()), expected)


@pytest.mark.parametrize("inf", [np.inf, -np.inf, float("inf"), float("-inf")])
Expand All @@ -176,7 +176,9 @@ def test_validate_allow_inf_nan(inf: Any, nan: Any):
column = dy.Float(allow_inf_nan=True)
lf = pl.LazyFrame({"a": pl.Series([inf, 2.0, nan, 4.0, 5.0])})
actual = evaluate_rules(lf, rules_from_exprs(column.validation_rules(pl.col("a"))))
assert len(actual.columns) == 0, "There should be no validation rules"
assert len(actual.collect_schema().names()) == 0, (
"There should be no validation rules"
)


def test_sample_unchecked_min_0():
Expand Down
2 changes: 1 addition & 1 deletion tests/columns/test_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ def test_nullability_rule(column_type: type[Column]):
lf = pl.LazyFrame({"a": [None]}, schema={"a": column.dtype})
actual = evaluate_rules(lf, rules_from_exprs(column.validation_rules(pl.col("a"))))
expected = pl.LazyFrame({"nullability": [False]})
assert_frame_equal(actual.select(expected.columns), expected)
assert_frame_equal(actual.select(expected.collect_schema().names()), expected)