Skip to content

style: Enforce type annotations#7

Merged
Oliver Borchert (borchero) merged 2 commits into
mainfrom
type-annotations
Apr 20, 2025
Merged

style: Enforce type annotations#7
Oliver Borchert (borchero) merged 2 commits into
mainfrom
type-annotations

Conversation

@borchero
Copy link
Copy Markdown
Member

Motivation

I think that it's generally good practice to enforce type annotations. This PR largely adds explicit -> None return annotations.

Changes

  • Set disallow_untyped_defs = true in the mypy options

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3cfe686) to head (9990d6a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1776      1776           
=========================================
  Hits          1776      1776           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@delsner Daniel Elsner (delsner) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread docs/sites/quickstart.rst Outdated
Co-authored-by: Daniel Elsner <dvelsner@gmail.com>
@borchero Oliver Borchert (borchero) enabled auto-merge (squash) April 20, 2025 08:35
@borchero Oliver Borchert (borchero) merged commit 2cf6a39 into main Apr 20, 2025
18 checks passed
@borchero Oliver Borchert (borchero) deleted the type-annotations branch April 20, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants