fix: Use covariant type annotation for collection sampling type#9
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 1788 1788
=========================================
Hits 1788 1788 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Daniel Elsner (delsner)
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Providing a custom sampling type does not actually work all too well right now (or, rather, not at all) as
MutableMappingis invariant. Afaict, there's no way around usingMappinghere which is not quite as accurate but makes no practical difference asdataframelyitself never mutates the sample (i.e. it only needs to be mutable from the user's perspective who knows the concrete type).