Skip to content

fix: Use covariant type annotation for collection sampling type#9

Merged
Oliver Borchert (borchero) merged 3 commits into
mainfrom
mapping
Apr 23, 2025
Merged

fix: Use covariant type annotation for collection sampling type#9
Oliver Borchert (borchero) merged 3 commits into
mainfrom
mapping

Conversation

@borchero
Copy link
Copy Markdown
Member

Motivation

Providing a custom sampling type does not actually work all too well right now (or, rather, not at all) as MutableMapping is invariant. Afaict, there's no way around using Mapping here which is not quite as accurate but makes no practical difference as dataframely itself never mutates the sample (i.e. it only needs to be mutable from the user's perspective who knows the concrete type).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (54cbc75) to head (211c3af).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         1788      1788           
=========================================
  Hits          1788      1788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@borchero Oliver Borchert (borchero) merged commit 698b701 into main Apr 23, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants