fix

Author: MariusMerkleQC

diffly/summary.py

@@ -563,11 +563,12 @@ def _section_columns(self) -> RenderableType:
                 "Column", max_width=COLUMN_SECTION_COLUMN_WIDTH, overflow=OVERFLOW
             )
             matches.add_column("Match Rate", justify="right")
-            if any(
+            has_top_changes_column = any(
                 self.top_k_changes_by_column[col_name] > 0
                 for col_name in self._comparison._other_common_columns
                 if self._comparison.fraction_same()[col_name] < 1
-            ):
+            )
+            if has_top_changes_column:
                 matches.add_column("Top Changes", justify="right")
             if self.show_perfect_column_matches:
                 max_col_len = max(
@@ -635,7 +636,7 @@ def _section_columns(self) -> RenderableType:
 
                     matches.add_row(*columns)
                     if (
-                        top_k_column_changes > 0
+                        has_top_changes_column
                         or max_col_len > COLUMN_SECTION_COLUMN_WIDTH
                     ):
                         matches.add_section()

tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt

@@ -20,6 +20,5 @@
  ▔▔▔▔▔▔▔
    ┌───────────┬─────────┬──┐
    │ speed_kph │ 100.00% │  │
-   ├───────────┼─────────┼──┤
    │ weight_kg │ 100.00% │  │
    └───────────┴─────────┴──┘

tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt

@@ -20,6 +20,5 @@
  ▔▔▔▔▔▔▔
    ┌───────────┬─────────┬──┐
    │ speed_kph │ 100.00% │  │
-   ├───────────┼─────────┼──┤
    │ weight_kg │ 100.00% │  │
    └───────────┴─────────┴──┘

tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt

@@ -22,8 +22,6 @@
  ▔▔▔▔▔▔▔
    ┌─────────────────┬─────────┬──┐
    │ life_expectancy │ 100.00% │  │
-   ├─────────────────┼─────────┼──┤
    │ speed_kph       │ 100.00% │  │
-   ├─────────────────┼─────────┼──┤
    │ weight_kg       │ 100.00% │  │
    └─────────────────┴─────────┴──┘

tests/summary/fixtures/equal_non_empty_different_columns/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt

@@ -22,9 +22,7 @@
  ▔▔▔▔▔▔▔
    ┌─────────────────┬─────────┬──┐
    │ life_expectancy │ 100.00% │  │
-   ├─────────────────┼─────────┼──┤
    │ speed_kph       │ 100.00% │  │
-   ├─────────────────┼─────────┼──┤
    │ weight_kg       │ 100.00% │  │
    └─────────────────┴─────────┴──┘
 

tests/summary/fixtures/gained_rows_only/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt

@@ -25,5 +25,6 @@
    │         │         │ 20.0 -> 25.0 (1x) │
    ├─────────┼─────────┼───────────────────┤
    │ card_id │  50.00% │                   │
+   ├─────────┼─────────┼───────────────────┤
    │ status  │ 100.00% │                   │
    └─────────┴─────────┴───────────────────┘