feedback copilot

Author: MariusMerkleQC

diffly/summary.py

@@ -137,7 +137,9 @@ def _compute_summary_data(
     hidden_columns = hidden_columns or []
 
     def _validate_primary_key_hidden_columns() -> None:
-        overlap = set(hidden_columns).intersection(set(comparison.primary_key or []))
+        overlap = sorted(
+            set(hidden_columns).intersection(set(comparison.primary_key or []))
+        )
         if overlap and sample_k_rows_only > 0:
             raise ValueError(
                 f"Cannot show sample rows only on the left or right side when primary"
@@ -343,7 +345,6 @@ def _validate_primary_key_hidden_columns() -> None:
 # ---------------------------------------------------------------------------- #
 
 
-@dataclass
 class Summary:
     """Container object for generating a summary of the comparison of two data frames.
 

tests/summary/test_summary.py

@@ -157,7 +157,7 @@ def _make_comparison() -> DataFrameComparison:
 @pytest.mark.parametrize(
     "show_perfect_column_matches, show_top_column_changes, slim, sample_rows, sample_pk, hide_value",
     [
-        (*combo[:2], combo[2], combo[3], combo[3] and combo[1], combo[4])
+        (combo[0], combo[1], combo[2], combo[3], combo[3] and combo[1], combo[4])
         for combo in itertools.product([True, False], repeat=5)
     ],
 )