Address comments

Author: kmilner

cryptomite/raz.py

@@ -366,8 +366,7 @@ def calc_raz_out(n_1: int,
                      min(floor(k_2) - m_init,
                          initial_tests), dtype=int)
     i = 0
-    STOP = 0
-    while STOP == 0:
+    while True:
         m = ms[i]
         if opt_error_raz(n_1, k_1, n_2, k_2, m,
                          max_tests_basic=max_tests_basic,
@@ -376,10 +375,10 @@ def calc_raz_out(n_1: int,
                          verbose=False) <= log2_error_tol:
             max_m = m
         else:
-            STOP = 1
+            break
         i += 1
         if i >= len(ms):
-            STOP = 1
+            break
     if detailed_opt:
         max_m += 1
         while opt_error_raz(n_1, k_1, n_2, k_2, max_m,
@@ -411,7 +410,7 @@ def from_params(
         k_2: float,
         log2_error: float,
         detailed_opt=False,
-        verbose: bool = True) -> Raz:
+        verbose: bool = False) -> Raz:
     """
     Generate a weak version of the efficient Raz
     extractor from [Fore2025]_ with valid

src/ntt.cpp

@@ -155,7 +155,7 @@ std::vector<uint32_t> NTT::conv(const std::vector<uint32_t> &a, const std::vecto
 }
 
 std::vector<uint32_t> NTT::conv_and_reduce(const std::vector<uint32_t> &a, const std::vector<uint32_t> &b, uint32_t r, uint32_t s) {
-    auto call_ntt = [this](const std::vector<uint32_t> &x, bool inverse){ return ntt(x, inverse); };
+    auto call_ntt = auto call_ntt = std::bind(&Ntt::ntt, this, std::placeholders::_1, std::placeholders::_2);;
     std::future<std::vector<uint32_t>> ntt_a = std::async(std::launch::async, call_ntt, a, false);
     std::future<std::vector<uint32_t>> ntt_b = std::async(std::launch::async, call_ntt, b, false);
     auto finish_and_reduce = [this](const std::vector<uint32_t> &x, const std::vector<uint32_t> &y, uint32_t r, uint32_t s){
@@ -174,10 +174,10 @@ std::vector<uint32_t> NTT::conv_and_reduce(const std::vector<uint32_t> &a, const
 }
 
 std::pair<std::vector<uint32_t>, std::vector<uint32_t>> NTT::raz_iteration(const std::vector<uint32_t> &product, const std::vector<uint32_t> &delta, uint32_t r, uint32_t s) {
-    auto call_ntt = [this](const std::vector<uint32_t> &x, bool inverse, bool plusone = false){ return ntt(x, inverse, plusone); };
-    std::future<std::vector<uint32_t>> ntt_delta = std::async(std::launch::async, call_ntt, delta, false);
+    auto call_ntt = std::bind(&Ntt::ntt, this, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3);;
+    std::future<std::vector<uint32_t>> ntt_delta = std::async(std::launch::async, call_ntt, delta, false, false);
     std::future<std::vector<uint32_t>> ntt_delta_p1 = std::async(std::launch::async, call_ntt, delta, false, true);
-    std::future<std::vector<uint32_t>> ntt_product = std::async(std::launch::async, call_ntt, product, false);
+    std::future<std::vector<uint32_t>> ntt_product = std::async(std::launch::async, call_ntt, product, false, false);
 
 
     auto finish_and_reduce = [this](const std::vector<uint32_t> &x, const std::vector<uint32_t> &y, uint32_t r, uint32_t s){