Skip to content

refactor!: Delete redundant error message#1767

Merged
croyzor merged 1 commit into
mainfrom
cr/delete-old-error
May 27, 2026
Merged

refactor!: Delete redundant error message#1767
croyzor merged 1 commit into
mainfrom
cr/delete-old-error

Conversation

@croyzor
Copy link
Copy Markdown
Collaborator

@croyzor croyzor commented May 26, 2026

This error was erroneously merged in #1754, but isn't needed for protocol checking. Pulling its removal into a separate PR so that #1765 can be non-breaking

BREAKING CHANGE: Remove NoAnnotationHint error message from guppylang-internals

@croyzor croyzor requested a review from a team as a code owner May 26, 2026 15:39
@croyzor croyzor requested a review from tatiana-s May 26, 2026 15:39
@croyzor croyzor changed the title cleanup!: Delete redundant error message refactor!: Delete redundant error message May 26, 2026
@hugrbot
Copy link
Copy Markdown
Collaborator

hugrbot commented May 26, 2026

This PR contains breaking changes to the public Python API.

Breaking changes summary
guppylang-internals/src/guppylang_internals/definition/protocol.py:0: NoAnnotationHint:
Public object was removed


@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

🐰 Bencher Report

Branchcr/delete-old-error
TestbedLinux
Click to view all benchmark results
Benchmarkhugr_bytesBenchmark Result
bytes x 1e3
(Result Δ%)
Upper Boundary
bytes x 1e3
(Limit %)
hugr_nodesBenchmark Result
nodes
(Result Δ%)
Upper Boundary
nodes
(Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compile📈 view plot
🚷 view threshold
158.77 x 1e3
(0.00%)Baseline: 158.77 x 1e3
160.36 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
6,641.00
(0.00%)Baseline: 6,641.00
6,707.41
(99.01%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile📈 view plot
🚷 view threshold
27.53 x 1e3
(0.00%)Baseline: 27.53 x 1e3
27.81 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
1,074.00
(0.00%)Baseline: 1,074.00
1,084.74
(99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile📈 view plot
🚷 view threshold
10.91 x 1e3
(0.00%)Baseline: 10.91 x 1e3
11.02 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
308.00
(0.00%)Baseline: 308.00
311.08
(99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile📈 view plot
🚷 view threshold
14.84 x 1e3
(-0.01%)Baseline: 14.84 x 1e3
14.99 x 1e3
(99.00%)
📈 view plot
🚷 view threshold
435.00
(0.00%)Baseline: 435.00
439.35
(99.01%)
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (82b9c77) to head (86c0763).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
- Coverage   92.98%   92.98%   -0.01%     
==========================================
  Files         135      135              
  Lines       13056    13053       -3     
==========================================
- Hits        12140    12137       -3     
  Misses        916      916              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@croyzor croyzor enabled auto-merge May 26, 2026 15:46
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 26, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing cr/delete-old-error (86c0763) with main (82b9c77)

Open in CodSpeed

@croyzor croyzor added this pull request to the merge queue May 27, 2026
@maximilianruesch maximilianruesch removed the request for review from tatiana-s May 27, 2026 09:08
Merged via the queue into main with commit 2dc589a May 27, 2026
17 of 18 checks passed
@croyzor croyzor deleted the cr/delete-old-error branch May 27, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants