Skip to content

feat: Allow protocol type args to be referenced in methods#1769

Open
croyzor wants to merge 1 commit into
cr/proto-checkfrom
cr/proto-type-args-in-methods
Open

feat: Allow protocol type args to be referenced in methods#1769
croyzor wants to merge 1 commit into
cr/proto-checkfrom
cr/proto-type-args-in-methods

Conversation

@croyzor
Copy link
Copy Markdown
Collaborator

@croyzor croyzor commented May 27, 2026

Put the type args for a protocol into the context before parsing the self arg

@croyzor croyzor requested a review from a team as a code owner May 27, 2026 14:56
@croyzor croyzor requested review from aborgna-q and removed request for a team May 27, 2026 14:56
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

🐰 Bencher Report

Branchcr/proto-type-args-in-methods
TestbedLinux
Click to view all benchmark results
Benchmarkhugr_bytesBenchmark Result
bytes x 1e3
(Result Δ%)
Upper Boundary
bytes x 1e3
(Limit %)
hugr_nodesBenchmark Result
nodes
(Result Δ%)
Upper Boundary
nodes
(Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compile📈 view plot
🚷 view threshold
158.77 x 1e3
(0.00%)Baseline: 158.77 x 1e3
160.36 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
6,641.00
(0.00%)Baseline: 6,641.00
6,707.41
(99.01%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile📈 view plot
🚷 view threshold
27.53 x 1e3
(0.00%)Baseline: 27.53 x 1e3
27.81 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
1,074.00
(0.00%)Baseline: 1,074.00
1,084.74
(99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile📈 view plot
🚷 view threshold
10.91 x 1e3
(0.00%)Baseline: 10.91 x 1e3
11.02 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
308.00
(0.00%)Baseline: 308.00
311.08
(99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile📈 view plot
🚷 view threshold
14.84 x 1e3
(0.00%)Baseline: 14.84 x 1e3
14.98 x 1e3
(99.01%)
📈 view plot
🚷 view threshold
435.00
(0.00%)Baseline: 435.00
439.35
(99.01%)
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (2083883) to head (eb5ed49).

Additional details and impacted files
@@                Coverage Diff                 @@
##           cr/proto-check    #1769      +/-   ##
==================================================
- Coverage           93.30%   93.27%   -0.03%     
==================================================
  Files                 136      136              
  Lines               13278    13280       +2     
==================================================
- Hits                12389    12387       -2     
- Misses                889      893       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@croyzor croyzor force-pushed the cr/proto-type-args-in-methods branch from fcce317 to eb5ed49 Compare May 27, 2026 15:01
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 27, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing cr/proto-type-args-in-methods (eb5ed49) with cr/proto-check (2083883)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants