made utilities and experiments compatible#9
Open
debobiswas01 wants to merge 4 commits into
Open
Conversation
Contributor
|
Let's just try and see if these run against the MultiVu in simulation mode please. |
added the . in __init__ file to import modules correctly changed the timing by sampling more number of points (math.ceil) and decreased wait time by changing points to (points-1)
comp-phys-marc
requested changes
Aug 8, 2024
comp-phys-marc
left a comment
Contributor
There was a problem hiding this comment.
Please remove the pycahce
comp-phys-marc
requested changes
Aug 12, 2024
comp-phys-marc
left a comment
Contributor
There was a problem hiding this comment.
One last thing, please add the pycache to the .gitignore so that it does not get generated and added automatically again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following changes in utilities folder:
added imports
also uses the save_data defined from utilities now
also made all experiments compatible with utilities