Incremental progress on getting rid of allowscalar

Author: kshyatt

Project.toml

@@ -53,3 +53,6 @@ TestExtras = "5ed8adda-3752-4e41-b88a-e8b09835ee3a"
 
 [targets]
 test = ["Test", "TestExtras", "Random", "Combinatorics", "SafeTestsets", "Aqua", "Adapt", "JLArrays"]
+
+[sources]
+Strided = {url = "https://github.com/QuantumKitHub/Strided.jl", rev = "ksh/jlarrays"}

test/abstracttensor/blocktensor.jl

@@ -5,7 +5,7 @@ using BlockTensorKit
 using Random
 using Combinatorics
 using Adapt
-using JLArrays
+using Strided, JLArrays
 
 Vtr = (
     SumSpace(ℂ^3),
@@ -86,12 +86,10 @@ end
         # test conversion to TensorMap that isn't backed by a Vector
         jl_bt1 = rand(JLVector{T}, W)
         TT = TensorKit.TensorMap{T, spacetype(t1′), numout(t1′), numin(t1′), JLVector{T}}
-        # The @allowscalar here can be removed once QuantumKitHub/Strided.jl#44 and
-        # QuantumKitHub/StridedViews.jl#31 are merged and new versions are tagged
-        JLArrays.@allowscalar begin # to avoid scalar indexing error in Strided
-            jl_bt1′ = @constinferred convert(TT, jl_bt1)
+        jl_bt1′ = @constinferred convert(TT, jl_bt1)
+        JLArrays.@allowscalar begin
             jl_bt1″ = @inferred BlockTensorMap(jl_bt1′, W)
-        end
+        end # still need some logic for copying to a BlockArray of StridedViews
         @test jl_bt1 ≈ jl_bt1″
     end
 end