Skip to content

Fix creation of dense similar for linalg#52

Merged
lkdvos merged 2 commits intoQuantumKitHub:mainfrom
kshyatt:ksh/dense
Apr 29, 2026
Merged

Fix creation of dense similar for linalg#52
lkdvos merged 2 commits intoQuantumKitHub:mainfrom
kshyatt:ksh/dense

Conversation

@kshyatt
Copy link
Copy Markdown
Member

@kshyatt kshyatt commented Apr 29, 2026

I think this should fix this for GPU arrays. It would be helpful to set up a build kite pipeline/JLArrays tests for this package at some point. Anyway, this is a bit ugly, but since the needed similar(::Type{TA},...) methods in Base aren't available on 1.10 and 1.12, it seemed like the simplest way...

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Your PR no longer requires formatting changes. Thank you for your contribution!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.20%. Comparing base (cf8a145) to head (aadf49a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/auxiliary/blockarrays.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   56.27%   56.20%   -0.08%     
==========================================
  Files          20       20              
  Lines        1434     1443       +9     
==========================================
+ Hits          807      811       +4     
- Misses        627      632       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like a very clean fix indeed!

@lkdvos lkdvos merged commit 1a08a65 into QuantumKitHub:main Apr 29, 2026
27 of 28 checks passed
@kshyatt kshyatt deleted the ksh/dense branch April 29, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants