Skip to content

Small fixes to let BlockTensorMaps work with GPU arrays #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lkdvos merged 7 commits into from
Feb 13, 2026
Merged

Small fixes to let BlockTensorMaps work with GPU arrays #44

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0c16631
Small fixes to let BlockTensorMaps work with GPU arrays
kshyatt Feb 13, 2026
9ba6e72
Indexing horror
kshyatt Feb 13, 2026
3a8f8bc
Update src/linalg/factorizations.jl
kshyatt Feb 13, 2026
ac30196
Use views
kshyatt Feb 13, 2026
d88a5d8
Add a check for blocksquarity
kshyatt Feb 13, 2026
a20c3f4
Update src/linalg/factorizations.jl
kshyatt Feb 13, 2026
3bfe9c6
No checks full gas
kshyatt Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/linalg/factorizations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using MatrixAlgebraKit
using MatrixAlgebraKit: AbstractAlgorithm, YALAPACK.BlasMat, Algorithm
using MatrixAlgebraKit: AbstractAlgorithm, YALAPACK.BlasMat, Algorithm, diagview
import MatrixAlgebraKit as MAK

# Type piracy for defining the MAK rules on BlockArrays!
Expand All @@ -9,8 +9,11 @@ const BlockBlasMat{T <: MAK.BlasFloat} = BlockMatrix{T}

function MatrixAlgebraKit.one!(A::BlockBlasMat)
_one, _zero = one(eltype(A)), zero(eltype(A))
@inbounds for j in axes(A, 2), i in axes(A, 1)
A[i, j] = ifelse(i == j, _one, _zero)
A .= _zero
n_blocks = blocksize(A)[1]
# awful workaround to BlockArrays indexing interface
for bi in 1:n_blocks
A[Block(bi), Block(bi)] .= diagm(fill(_one, blocksizes(A)[bi, bi][1]))
Comment thread
kshyatt marked this conversation as resolved.
Outdated
end
return A
end
Expand Down
12 changes: 6 additions & 6 deletions src/tensors/blocktensor.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,10 @@ end
# ------------------------
for (fname, felt) in ((:zeros, :zero), (:ones, :one))
@eval begin
function Base.$fname(::Type{T}, V::TensorMapSumSpace) where {T}
TT = blocktensormaptype(spacetype(V), numout(V), numin(V), T)
function Base.$fname(::Type{TorA}, V::TensorMapSumSpace) where {TorA}
TT = blocktensormaptype(spacetype(V), numout(V), numin(V), TorA)
t = TT(undef, V)
fill!(t, $felt(T))
fill!(t, $felt(scalartype(t)))
return t
end
end
Expand All @@ -136,9 +136,9 @@ for randfun in (:rand, :randn, :randexp)
randfun! = Symbol(randfun, :!)
@eval begin
function Random.$randfun(
rng::Random.AbstractRNG, ::Type{T}, V::TensorMapSumSpace
) where {T}
TT = blocktensormaptype(spacetype(V), numout(V), numin(V), T)
rng::Random.AbstractRNG, ::Type{TorA}, V::TensorMapSumSpace
) where {TorA}
TT = blocktensormaptype(spacetype(V), numout(V), numin(V), TorA)
t = TT(undef, V)
Random.$randfun!(rng, t)
return t
Expand Down