careful with jordanmpotensortype

Co-authored-by: Katharine Hyatt <khyatt@flatironinstitute.org>

Author: lkdvos

src/operators/jordanmpotensor.jl

@@ -121,15 +121,16 @@ function JordanMPOTensor(W::SparseBlockTensorMap{TT, E, S, 2, 2}) where {TT, E,
     )
 end
 
-function jordanmpotensortype(::Type{S}, ::Type{E}) where {S <: VectorSpace, E <: Number}
-    TA = Union{tensormaptype(S, 2, 2, E), BraidingTensor{E, S}}
+function jordanmpotensortype(::Type{S}, ::Type{E}) where {S <: VectorSpace, E}
+    TA = tensormaptype(S, 2, 2, E)
+    Tτ = BraidingTensor{scalartype(TA), S}
     TB = tensormaptype(S, 2, 1, E)
     TC = tensormaptype(S, 1, 2, E)
     TD = tensormaptype(S, 1, 1, E)
-    return JordanMPOTensor{E, S, TA, TB, TC, TD}
+    return JordanMPOTensor{E, S, Union{TA, Tτ}, TB, TC, TD}
 end
-function jordanmpotensortype(::Type{O}) where {O <: MPOTensor}
-    return jordanmpotensortype(spacetype(O), scalartype(O))
+function jordanmpotensortype(::Type{O}) where {O <: AbstractTensorMap}
+    return jordanmpotensortype(spacetype(O), storagetype(O))
 end
 
 function Base.similar(W::JordanMPOTensor, ::Type{T}) where {T <: Number}

src/operators/mpohamiltonian.jl

@@ -437,7 +437,6 @@ function FiniteMPOHamiltonian(lattice::AbstractArray{<:VectorSpace}, local_opera
 
     # construct the sparse MPO
     T = _find_tensortype(nonzero_opps)
-    E = scalartype(T)
     S = spacetype(T)
 
     # avoid using one(S)
@@ -465,7 +464,7 @@ function FiniteMPOHamiltonian(lattice::AbstractArray{<:VectorSpace}, local_opera
     end
 
     # construct the tensor
-    TW = jordanmpotensortype(S, E)
+    TW = jordanmpotensortype(T)
     Os = map(1:length(lattice)) do site
         V = virtualsumspaces[site] * lattice[site] ←
             lattice[site] * virtualsumspaces[site + 1]
@@ -476,7 +475,7 @@ function FiniteMPOHamiltonian(lattice::AbstractArray{<:VectorSpace}, local_opera
             key_R = key_R′ == 0 ? length(virtualsumspaces[site + 1]) : key_R′
             O[key_L, 1, 1, key_R] += if o isa Number
                 iszero(o) && continue
-                τ = BraidingTensor{E}(eachspace(O)[key_L, 1, 1, key_R])
+                τ = BraidingTensor{scalartype(TW)}(eachspace(O)[key_L, 1, 1, key_R])
                 isone(o) ? τ : τ * o
             else
                 o
@@ -520,7 +519,6 @@ function InfiniteMPOHamiltonian(lattice′::AbstractArray{<:VectorSpace}, local_
 
     # construct the sparse MPO
     T = _find_tensortype(nonzero_opps)
-    E = scalartype(T)
     S = spacetype(T)
 
     # construct the virtual spaces
@@ -588,7 +586,7 @@ function InfiniteMPOHamiltonian(lattice′::AbstractArray{<:VectorSpace}, local_
     end
 
     # construct the tensor
-    TW = jordanmpotensortype(S, E)
+    TW = jordanmpotensortype(T)
     Os = map(1:length(lattice)) do site
         V = virtualsumspaces[site - 1] * lattice[site] ←
             lattice[site] * virtualsumspaces[site]
@@ -599,7 +597,7 @@ function InfiniteMPOHamiltonian(lattice′::AbstractArray{<:VectorSpace}, local_
             key_R = key_R′ == 0 ? length(virtualspaces[site]) : key_R′
             O[key_L, 1, 1, key_R] += if o isa Number
                 iszero(o) && continue
-                τ = BraidingTensor{E}(eachspace(O)[key_L, 1, 1, key_R])
+                τ = BraidingTensor{scalartype(TW)}(eachspace(O)[key_L, 1, 1, key_R])
                 isone(o) ? τ : τ * o
             else
                 o