Add tests for fermionic periodic boundary conditions#274
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
leburgel
reviewed
Apr 13, 2025
Member
leburgel
left a comment
There was a problem hiding this comment.
Changes themselves look good to me. I think I understand the fix, but I have to say I don't really understand what the problem actually was.
Jutho
reviewed
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement fixes for handling fermionic periodic boundary conditions and adds some tests.
I have to say that this still absolutely confuses me, and I can't really wrap my head around this very well.
The bottom line is that if I understand everything correctly, even though our formalism works, it cannot correctly account for the anticommutation relations on different sites:
I don't think there is any way around this, but I might be mistaken here.
In any case, with this in mind, the previous implementation of PBC did not account for this, so here I added a twist on every link that needs to wrap around.
I think the tests should capture this correctly, but I'm still confused by this entire endeavor, since if I am understanding this correctly, for fermionic systems the following does not hold, while it is what I understand from translation invariance for bosonic systems:
@Jutho if you could confirm that this is indeed expected, that would be greatly appreciated.